427853 - Define nsIAbManager::getDirectory

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

As part of the refactoring, I now want to define nsIAbManager::getDirectory, for now this will enable us to "hide" the GetResource that the rdf service uses.

This patch defines the function, taking the URI of the rdf resource (as that is currently the only identifier we have), and uses it in all the unit tests.

I'll do actual code usages in a separate bug as I know there's at least one patch that should be coming soon that I'll bitrot if I do the code changes now.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix v2

New version to incorporate test_mailList1.js that I checked in earlier today.

Comment 2

[[e-mail]]

Comment on attachment 314601 [details] [diff] [review]
The fix v2

>+  nsCOMPtr<nsIRDFResource> parentResource;
>+  rv = rdfService->GetResource(aURI,
>+                               getter_AddRefs(parentResource));
>+  NS_ENSURE_SUCCESS(rv, rv);
What's it the parent of? Perhaps just call it dirResource?

>+  nsCOMPtr<nsIAbDirectory> dir(do_QueryInterface(parentResource, &rv));
>+  NS_ENSURE_SUCCESS(rv, rv);
>+
>+  dir.swap(*aResult);
>+  return NS_OK;
return CallQueryInterface(dirResource, aResult);

Comment 3

[Mark Banner (:standard8)]

Patch checked in with requested changes. Fixed.

Comment 4

[Bruno 'Aqualon' Escherl]

Responsible for increasing trace_malloc_leaks count on Linux nye Dep bloat?

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Responsible for increasing trace_malloc_leaks count on Linux nye Dep bloat?
> 
Highly unlikely considering this code isn't actually called anywhere within the app yet (only called from unit tests so far).