Closed Bug 427853 Opened 14 years ago Closed 14 years ago

Define nsIAbManager::getDirectory

Categories

(MailNews Core :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch The fix (obsolete) — Splinter Review
As part of the refactoring, I now want to define nsIAbManager::getDirectory, for now this will enable us to "hide" the GetResource that the rdf service uses.

This patch defines the function, taking the URI of the rdf resource (as that is currently the only identifier we have), and uses it in all the unit tests.

I'll do actual code usages in a separate bug as I know there's at least one patch that should be coming soon that I'll bitrot if I do the code changes now.
Attachment #314408 - Flags: superreview?(neil)
Attachment #314408 - Flags: review?(neil)
Attached patch The fix v2Splinter Review
New version to incorporate test_mailList1.js that I checked in earlier today.
Attachment #314408 - Attachment is obsolete: true
Attachment #314601 - Flags: superreview?(neil)
Attachment #314601 - Flags: review?(neil)
Attachment #314408 - Flags: superreview?(neil)
Attachment #314408 - Flags: review?(neil)
Comment on attachment 314601 [details] [diff] [review]
The fix v2

>+  nsCOMPtr<nsIRDFResource> parentResource;
>+  rv = rdfService->GetResource(aURI,
>+                               getter_AddRefs(parentResource));
>+  NS_ENSURE_SUCCESS(rv, rv);
What's it the parent of? Perhaps just call it dirResource?

>+  nsCOMPtr<nsIAbDirectory> dir(do_QueryInterface(parentResource, &rv));
>+  NS_ENSURE_SUCCESS(rv, rv);
>+
>+  dir.swap(*aResult);
>+  return NS_OK;
return CallQueryInterface(dirResource, aResult);
Attachment #314601 - Flags: superreview?(neil)
Attachment #314601 - Flags: superreview+
Attachment #314601 - Flags: review?(neil)
Attachment #314601 - Flags: review+
Patch checked in with requested changes. Fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Responsible for increasing trace_malloc_leaks count on Linux nye Dep bloat?
(In reply to comment #4)
> Responsible for increasing trace_malloc_leaks count on Linux nye Dep bloat?
> 
Highly unlikely considering this code isn't actually called anywhere within the app yet (only called from unit tests so far).
Flags: in-testsuite+
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.