427973 - Remove cookies button shifts

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

When opening Tools->Options->Privacy 

Click the 'show cookies' button 
When you have a site listed that has multiple cookies the button at the bottom for 'Remove Cookies'  will shift by 1- letter as it changes from:

Remove Cookie to Remove Cookies 

Button should NOT resize..

Comment 1

[Carsten Book [:Tomcat]]

changing OS to ALL...i can see this also on Mac 10.5 and XP

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Being as no-one is looking at this, and it appears no-where on any of the easy/hard UI fix-lists, I'm closing this as INVALID.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Might as well keep it open since it is a legitimate problem, just a low visibility one.

Comment 4

[David Dahl :ddahl]

As a low visibility bug sounds like a good one to claim as my first:)

I was chatting with rs about this problem, we discussed different approaches that would all be a bit hacky as we do not know how long the button will be for each locale. Robb said we could just flip the two buttons and the button movement would pretty much go away. What do you think? - ddahl

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm not sure I'm comfortable flipping the buttons, as "Remove All Cookies" is really destructive and doesn't have a confirmation button (bug ?) or an undo (bug 285836) function.

In order to not break string freeze, and to fix the jitter, I'd suggest just always using the plural entity ("Remove Cookies" in english) and not switching back and forth.

Comment 6

[David Dahl :ddahl]

Attachment: forcing the "remove cookies" button to always use the plural string

forcing the "remove cookies" button to always use the plural string, also removed code that supported figuring out if there are more than 1 cookie per domain.

Comment 7

[David Dahl :ddahl]

Attachment: trunk patch as per rstrong's guidance

Removed preferences.properties that are redundant, changed the name of cookies.dtd entities to fully clean up this patch

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

mconnor suggests "remove selected"

In general action buttons are supposed to be specific.  It's hard to say that getting the plural right is a whole lot better than not shifting, or vice versa.  Perhaps we should just fix this bug when we start up development for 3.2 since we are after the string freeze?  Or we could just land the current patch and fix the plural thing later.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> mconnor suggests "remove selected"

This wouldn't solve it for locales where "selected" changes depending on the item count.

Comment 11

[Dão Gottwald [:dao]]

Attachment: fix the button size

Comment 12

[Dão Gottwald [:dao]]

Attachment: fix the button size, v2

This is slightly less messy. (There were also some parentheses missing in the previous patch.)

Comment 13

[David Dahl :ddahl]

I just applied your patch. Does this work with all locales as well?

Comment 14

[Dão Gottwald [:dao]]

Yes, should work for all locales.

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.

Problem should be pretty obvious, but buried kind of deep in our UI.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 356328 [details] [diff] [review]
fix the button size, v2

>diff --git a/browser/components/preferences/cookies.xul b/browser/components/preferences/cookies.xul

>+      <deck>
>+        <button id="removeCookie" disabled="true" icon="remove"
>+                label="&button.removecookie.label;" accesskey="&button.removecookie.accesskey;"
>+                oncommand="gCookiesWindow.deleteCookie();"/>
>+        <button id="removeCookies" disabled="true" icon="remove"
>+                label="&button.removecookies.label;" accesskey="&button.removecookie.accesskey;"
>+                oncommand="gCookiesWindow.deleteCookie();"/>
>+      </deck>

could put the oncommand on the <deck>

Comment 17

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/f31a8b89f5dc

Comment 18

[Jim Jeffery not reading bug-mail 1/2/11]

Verfied Fixed using hourly build:

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20100124 Minefield/3.7a1pre ID:20100124101409
cset: http://hg.mozilla.org/mozilla-central/rev/b3b2e90f743d