427987 - Add support for Hildon (Maemo) tap-n-hold context menu

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Maemo applications, mobile Nokia n810, for example, use a "tap-n-hold" metaphor to display context popup menus. Supporting the Hildon context menu is important for any Mozilla mobile work (and XUL apps in general) on that platform.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: fires context menu event on click and hold

just reuses code originally written for os x

Perhaps we should have an NS_TOUCHSCREEN flag for things that are generally useful for touch screens.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Brad, can we get this landed?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

sure, as soon as the tree thaws

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 332241 [details] [diff] [review]
fires context menu event on click and hold

a=beltzner

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 332241 [details] [diff] [review]
fires context menu event on click and hold

We're closing up for beta2 and this hasn't landed yet, so we'll hold off until after we branch.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Mike, sorry for not closing the bug out.  This landed Monday

http://hg.mozilla.org/mozilla-central/rev/f88dbbaa6364

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: uses MOZ_PLATFORM_HILDON

it looks like bug 453867 changed NS_HILDON to MOZ_PLATFORM_HILDON, so the previous patch actually had no effect.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 353337 [details] [diff] [review]
uses MOZ_PLATFORM_HILDON

File a followup on NS_TOUCHSCREEN?

Comment 9

[Stuart Parmenter]

can we close this bug out?

Comment 10

[Doug Turner (:dougt)]

on windows mobile, we recently disabled support for "Tap-and-hold" events.  do we continue wanting to support them?  I do not like having it supported on one platform, but not all.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

I think we should turn them back on for windows mobile.  But the patch on this bug landed so I'm closing it.

http://hg.mozilla.org/mozilla-central/rev/f88dbbaa6364

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 353337 [details] [diff] [review]
uses MOZ_PLATFORM_HILDON

a191=beltzner

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/edfeb149dc12

Comment 14

[Karl Tomlinson (:karlt)]

Is this still wanted on 1.9.1?

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #14)
> Is this still wanted on 1.9.1?

Yes, please.

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a9065ea92493