428013 - crash [@ nsPrintEngine::DocumentReadyForPrinting() ] when page is drag&drop to Print Preview window after printing

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Adam Hauner]

Repro:
1. open a web page
2. open Print Preview
3. print something to a printer
4. drag&drop HTML file to Print Preview window

-> crash

http://crash-stats.mozilla.com/report/index/005608e8-064a-11dd-8867-001cc45a2ce4
http://crash-stats.mozilla.com/report/index/c0c61985-0649-11dd-aea0-001321b13766

Signature	nsPrintEngine::DocumentReadyForPrinting()
Product		Firefox
Version		3.0pre
Build ID	2008040805
OS		Windows NT
OS Version	5.1.2600 Service Pack 2
CPU		x86
CPU Info	GenuineIntel family 6 model 14 stepping 8
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x30

Stacktrace:
nsPrintEngine::DocumentReadyForPrinting()
	 mozilla/layout/printing/nsPrintEngine.cpp:1466
xul.dll@0x2be260
DocumentViewerImpl::Show()
	mozilla/layout/base/nsDocumentViewer.cpp:1844
nsPresContext::EnsureVisible(int)
	mozilla/layout/base/nsPresContext.cpp:1460
PresShell::UnsuppressAndInvalidate()
	mozilla/layout/base/nsPresShell.cpp:4327
PresShell::UnsuppressPainting()
	mozilla/layout/base/nsPresShell.cpp:4387
DocumentViewerImpl::LoadComplete(unsigned int)
	mozilla/layout/base/nsDocumentViewer.cpp:1013
nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, unsigned int)
	mozilla/docshell/base/nsDocShell.cpp:5061
nsWebShell::EndPageLoad(nsIWebProgress*, nsIChannel*, unsigned int)
	mozilla/docshell/base/nsWebShell.cpp:1013
nsCOMPtr_base::assign_from_qi(nsQueryInterface, nsID const&)
	nsCOMPtr.cpp:96
nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, unsigned int)
	mozilla/docshell/base/nsDocShell.cpp:4966 

Bug 416920 has same signature, but different stacktrace.

Comment 1

[Martijn Wargers (dead)]

Bug 444843 is related to this.

Comment 2

[Martijn Wargers (dead)]

Attachment: patch

This seems to fix it and the other bug I mentioned.

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase

Making a mochitest that test this kind of bug turns out to be quite hairy.

Comment 4

[Eli Friedman]

Comment on attachment 339265 [details] [diff] [review]
patch

This is okay, but please put a fat comment explaining that calling SetIsPrinting while in print preview confuses the document viewer, and that this is safe because we prevent exiting print preview while printing.

Comment 5

[Martijn Wargers (dead)]

Attachment: mochitest

Thanks for the review, Eli. Perhaps you also have some tips on how to make the mochitest better. Especially the timers are bad. I've made them so big, because otherwise they might fail in my debug build (which is really slow). Ideally, I would use a more reliable method of executing, instead of using timers, but I have no idea how.

Comment 6

[Martijn Wargers (dead)]

Eli, see my attempt at making a mochitest for this and comment 5. Btw, this mochitest will leak too, which is bug 408355.

Comment 7

[Eli Friedman]

(In reply to comment #6)
> Eli, see my attempt at making a mochitest for this and comment 5. Btw, this
> mochitest will leak too, which is bug 408355.

Sorry, I don't have any suggestions there... the current printing code is rather unpleasant :(.

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 339265 [details] [diff] [review]
patch

Ok, well, I'm not sure the mochitest should be checked in in this state, it just seems to fragile.

Comment 9

[Martijn Wargers (dead)]

Attachment: patch, with Eli's comment in it

Comment 10

[Martijn Wargers (dead)]

Perhaps, it still would be wise to check in the mochitest? If it would cause trouble, then it could be disabled. But perhaps the timers make it too slow a test anyway?

Comment 11

[Martijn Wargers (dead)]

Checked in:
$ hg tip
changeset:   24061:ade1e110f6fb
tag:         tip
user:        Martijn Wargers <[e-mail]>
date:        Thu Jan 22 16:36:25 2009 +0100
summary:     Bug 428013 - crash [@ nsPrintEngine::DocumentReadyForPrinting() ] w
hen page is drag&drop to Print Preview window after printing, r=sharparrow1, sr=
roc

It might be easier to get a suitable mochitest for this, if bug 422949 is fixed.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 339352 [details] [diff] [review]
patch, with Eli's comment in it

a191=beltzner

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e9032baaad92

Comment 14

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.1 branch using : Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090520 Shiretoko/3.5b5pre. I don't see the crash following the STR in Comment 0. Adding keyword.