428020 - Library infoPane does not shrink if localstore has an height set up

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

After landing of bug 403140 the infoPane in the right of the Library is no more resizable, but the old height could still be set up in the localstore.rdf for
it. It should shrink when nothing is selected to leave some more space, but if
the height is set up there it does not shrink.

Drivers: should we change the infoPane id so height is discarded, or annotate this for beta users (suggesting to delete localstore)?

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

What's the impact here? What do you mean by annotate it? Relnote? Did we set up the height in localstore?

Comment 2

[Marco Bonardo [:mak]]

no, for annotate i mean adding this into the KB page that QA is preparing for beta users, bug 426340.

impact is that you loose some precious space from the results tree, and have white space under options in the infoPane. the worst case is if you had closed Library with the details pane open (more clicked) or resized to be bigger, then you upgrade, most probably half of Library right pane is lost in this case and you can't resize it anymore.

We persisted height before, so we were saving it in localstore

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Not auto resized details pane

Like Marco said, if the height is persistent within the localstore.rdf the details pane isn't auto sized.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch

change the id from infoPane to infoPaneBox

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Not a blocker, but good cleanup if we get a reviewed patch.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 314830 [details] [diff] [review]
patch

places.js calss getElementById("infoBox"), and there are few more references in pinstripe.

Comment 7

[Marco Bonardo [:mak]]

(In reply to comment #6)
> (From update of attachment 314830 [details] [diff] [review])
> places.js calss getElementById("infoBox"), and there are few more references in
> pinstripe.
> 

i'm not touching infoBox, i'm changing infoPane...

Comment 8

[Asaf Romano (gone)]

Comment on attachment 314830 [details] [diff] [review]
patch

ugh, sorry, r=mano.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 314830 [details] [diff] [review]
patch

asking approval to fix a bad behaviour for beta users (infopane steal space in the Lbrary, see screenshot above)

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314830 [details] [diff] [review]
patch

a1.9=beltzner

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314830 [details] [diff] [review]
patch

a1.9=beltzner

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/places/content/places.js 	1.155
mozilla/browser/components/places/content/places.xul 	1.130
mozilla/browser/themes/gnomestripe/browser/places/organizer.css 	1.15
mozilla/browser/themes/pinstripe/browser/places/organizer.css 	1.12
mozilla/browser/themes/winstripe/browser/places/organizer.css 	1.11

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with the following builds. Switching through the bookmarks, folders and tags automatically shrinks the details pane now for existing profiles.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041506 Minefield/3.0pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041504 Minefield/3.0pre ID:2008041504

Comment 14

[Aakash Desai [:aakashd]]

Test cases were created on 3.0 and 3.1 test runs on litmus for regression testing.

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7533

For 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7534

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv