Closed
Bug 428031
Opened 16 years ago
Closed 16 years ago
Library shouldn't look like a cluster of random UI elements
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(4 files, 1 obsolete file)
|
28.59 KB,
image/png
|
Details | |
|
28.72 KB,
image/png
|
Details | |
|
63.33 KB,
image/png
|
faaborg
:
ui-review+
|
Details |
|
1.32 KB,
patch
|
asaf
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
screenshot
The Library window uses too much of the Window background (usually white). This is right for trees and lists. But it makes form and toolbar elements look unattached and produces a frankensteinesque overall picture. The background for forms and toolbars needs to be -moz-dialog.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #314617 -
Flags: ui-review?(beltzner)
|
|
Assignee | |
Updated•16 years ago
|
|
|
Assignee | |
Comment 2•16 years ago
|
||
|
||
Comment 3•16 years ago
|
||
Maybe use toolbox for the back of the context bar? Otherwise totally agree.
Blocks: 425582
|
|
Assignee | |
Comment 4•16 years ago
|
||
Yes, the toolbox appearance works well for this.
Attachment #314643 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•16 years ago
|
Attachment #314617 -
Attachment description: how it should look like → how it should look like (classic)
|
|
||
Comment 5•16 years ago
|
||
Note that on vista we should match the style of media collection apps and go with the cluster of random UI elements (but on a gray background bug 403147) for Aero.
|
|
Assignee | |
Comment 6•16 years ago
|
||
Yes, I figured that, but it should be dealt with in bug 403147. That bug could turn out to be controversial e.g. by making the window look unstructured again or by causing issues as pointed out in bug 403147 comment 4. So I want to see bug 403147 as a potential second step rather than a requirement for this bug.
Blocks: 403147
|
|
Assignee | |
Updated•16 years ago
|
Attachment #314721 -
Flags: ui-review?(faaborg)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #314617 -
Flags: ui-review?(beltzner)
|
|
Assignee | |
Comment 7•16 years ago
|
||
Assignee: nobody → dao
Status: NEW → ASSIGNED
|
|
||
Comment 8•16 years ago
|
||
Comment on attachment 314721 [details]
Luna screenshots
Looks good, should also help a lot with classic themes.
Attachment #314721 -
Flags: ui-review?(faaborg) → ui-review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #314960 -
Flags: review?(mano)
|
||
Comment 9•16 years ago
|
||
Comment on attachment 314960 [details] [diff] [review] patch r=mano
Attachment #314960 -
Flags: review?(mano) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #314960 -
Flags: approval1.9?
|
||
Comment 10•16 years ago
|
||
Comment on attachment 314960 [details] [diff] [review] patch a1.9=beltzner
Attachment #314960 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 12•16 years ago
|
||
mozilla/browser/themes/winstripe/browser/places/organizer.css 1.10
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
|
||
Comment 13•16 years ago
|
||
Verified with bugMozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008052206 Minefield/3.0pre ID:2008052206
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•