428053 - Dehydra/Treehydra: pass strings from command line to JS

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Mandelin [:dmandelin]]

It would be nice if it were possible to pass control strings from the g++ command line through to JS, e.g., to run scripts in normal mode, test mode, or debug mode. Or to run an analysis on only selected functions in the C++ file.

We talked about this earlier, and I think Taras suggested it would go in the plugin-arg:

  g++ -fplugin-arg=gcc_treehydra.so,arbitrarystuff

We also need an API for exposing it to JS. A property on the global object seems like the natural choice, but what about the name? It's just one string, so "arg" seems like a decent name.

Comment 1

[(dormant account)]

I don't really like arg, but I don't have a better suggestion. Just wanted to mention that 
g++ -fplugin-arg=gcc_treehydra.so,arbitrarystuff,boo should end up as
arg=arbitrarystuff,boo

Also, are we happy with, as a separator instead of ; or something?

Comment 2

[David Mandelin [:dmandelin]]

I hesitated myself on arg, but I couldn't come up with anything better. Agree with your clarification. 

I chose ',' because it doesn't require any shell quoting. But now I realize that if you want to have a function decl as one part of the arg string, it would get more annoying to have additional parts. So ';' may be a better choice. Other thoughts?

Comment 3

[David Mandelin [:dmandelin]]

Attachment: Proposed patch

I went with the name 'args' and ';' as the separator. I added a test case for the args.

Comment 4

[Benjamin Smedberg]

Attachment: set _arguments for the string, arguments is an array, and use space delimiters

Comment 5

[Benjamin Smedberg]

Pushed with a change recommeded by dmandelin.