Closed Bug 428078 Opened 16 years ago Closed 16 years ago

test_bug356370.js (extension manager xpcshell test) fails in debug builds

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla1.9.1a2

People

(Reporter: benjamin, Assigned: mossop)

References

Details

(Keywords: assertion)

Attachments

(1 file, 2 obsolete files)

Running 'make check' in a debug build:

FAIL
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug356370.js.log:
>>>>>>>
*** test pending
*** Item Installed via directory addition to Install Location: app-global Item ID: {972ce4c6-7e08-4474-a285-3208198ce6fd}, attempting to register...
*** Item Installed/Upgraded at Install Location: app-global Item ID: {972ce4c6-7e08-4474-a285-3208198ce6fd}, attempting to register...
*** ... success, item installed but is not compatible
resource file:///builds/mozilla-central/ff-debug/dist/bin/chrome/app-chrome.manifest doesn't exist!
resource file:///builds/mozilla-central/ff-debug/dist/bin/chrome/app-chrome.manifest doesn't exist!
*** Item bug356370_2@tests.mozilla.org">bug356370_2@tests.mozilla.org was installed in an unknown location, removing.
*** Activating item bug356370_2@tests.mozilla.org">bug356370_2@tests.mozilla.org in app-profile
*** Item Installed/Upgraded at Install Location: app-profile Item ID: bug356370_2@tests.mozilla.org">bug356370_2@tests.mozilla.org, attempting to register...
*** ... success, item is compatible
*** Item bug356370_3@tests.mozilla.org">bug356370_3@tests.mozilla.org was installed in an unknown location, removing.
###!!! ASSERTION: attempted to open a new window with no WindowCreator: 'mWindowCreator', file ../../../../../src/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 648

This happens not to be turning the Firefox unit-test boxes orange because they don't build debug... but it's not pretty that 'make check' fails in normal debug builds ;-)
This is basically trying to open the app updates window during the xpcshell test. I don't think there is a way I can get round this in the current tests, I have to come up with a new way of testing the EM.
Summary: extension manager xpcshell tests fail in debug builds → test_bug356370.js (extension manager xpcshell test) fails in debug builds
Can we please disable the test in the meantime, so that people don't waste time debugging it / looking for the relevant bug?
Keywords: assertion
OS: Linux → All
Version: unspecified → Trunk
Attached patch disable the test (obsolete) — Splinter Review
Attachment #325178 - Flags: review?(dtownsend)
(In reply to comment #5)
> Can we please disable the test in the meantime, so that people don't waste time
> debugging it / looking for the relevant bug?
> 
IMHO I don't think disabling is the right solution. Especially as if you disable this one, you also need to disable others that fail in debug as per http://wiki.mozilla.org/MailNews:Automated_Testing#xpcshell_tests

A better solution would be to a) publicise the relevant tests, b) fix them, c) set up a debug unit test box to catch regressions.
Comment on attachment 325178 [details] [diff] [review]
disable the test

The test is still useful on the tinderboxes to make sure we don't regress it.

I think however we can fix the test by adding a fake proxy for nsIWindowWatcher which the EM is using to attempt to open the updates window. That should get rid of the assertion. If anyone has a moment to do that I can review it pretty quick otherwise I'll try to get to it this week.
Attachment #325178 - Flags: review?(dtownsend) → review-
Attached patch patch rev 1 (obsolete) — Splinter Review
Silently ignore attempts to open the update window.
Attachment #325178 - Attachment is obsolete: true
Attachment #330934 - Flags: review?(robert.bugzilla)
Status: NEW → ASSIGNED
Mossop - please see bug 446219, your fix here may be useful elsewhere.
Comment on attachment 330934 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/test/unit/test_bug356370.js b/toolkit/mozapps/extensions/test/unit/test_bug356370.js
>--- a/toolkit/mozapps/extensions/test/unit/test_bug356370.js
>+++ b/toolkit/mozapps/extensions/test/unit/test_bug356370.js
>@@ -30,16 +30,39 @@
>...
>+var WindowWatcherFactory = {
>+  createInstance: function createInstance(outer, iid) {
>+    if (outer != null)
>+      throw Components.results.NS_ERROR_NO_AGGREGATION;
>+    return promptService.QueryInterface(iid);
promptService isn't defined.
Attachment #330934 - Flags: review?(robert.bugzilla) → review-
(In reply to comment #11)
> (From update of attachment 330934 [details] [diff] [review])
> >diff --git a/toolkit/mozapps/extensions/test/unit/test_bug356370.js b/toolkit/mozapps/extensions/test/unit/test_bug356370.js
> >--- a/toolkit/mozapps/extensions/test/unit/test_bug356370.js
> >+++ b/toolkit/mozapps/extensions/test/unit/test_bug356370.js
> >@@ -30,16 +30,39 @@
> >...
> >+var WindowWatcherFactory = {
> >+  createInstance: function createInstance(outer, iid) {
> >+    if (outer != null)
> >+      throw Components.results.NS_ERROR_NO_AGGREGATION;
> >+    return promptService.QueryInterface(iid);
> promptService isn't defined.

Oops. Wonder how that still fixed the test :s
Here is the relevant part of the log
*** test pending
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "promptService is not defined" {file: "../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug356370.js" line: 53}]' when calling method: [nsIFactory::createInstance]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///c:/moz/1_9/ff-debug/dist/bin/components/nsExtensionManager.js :: anonymous :: line 3744"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: file:///c:/moz/1_9/ff-debug/dist/bin/components/nsExtensionManager.js :: anonymous :: line 3744"  data: no]
************************************************************
checkForMismatches threw an exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: file:///c:/moz/1_9/ff-debug/dist/bin/components/nsExtensionManager.js :: anonymous :: line 3744"  data: no]
Product: Firefox → Toolkit
Flags: wanted1.9.1?
Attached patch patch rev 2Splinter Review
Ok this works better. No exceptions in the log and the test correctly fails if I change the expected url for the openWindow call
Attachment #330934 - Attachment is obsolete: true
Attachment #333203 - Flags: review?(robert.bugzilla)
Attachment #333203 - Flags: review?(robert.bugzilla) → review+
Landed: http://hg.mozilla.org/index.cgi/mozilla-central/rev/857989de0a21
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080812190058 Minefield/3.1a2pre] (home, debug) (W2Ksp4)

V.Fixed
Status: RESOLVED → VERIFIED
Flags: wanted1.9.1?
Hardware: PC → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: