428136 - MXR text search broken

Status: RESOLVED FIXED

(Webtools Graveyard :: MXR, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Text search seems to be generally broken and returns far too few results: Here are a couple of querys that should return many more results than it does:

http://mxr.mozilla.org/mozilla/search?string=SetAttr(kNameSpace&find=&tree=mozilla

This gives "Found 15 matching lines in 5 files"
But misses out the call in for example nsSliderFrame.cpp

Another example is
http://mxr.mozilla.org/mozilla/search?string=SetAttr&find=layout&tree=mozilla
Which isn't searching all files in layout. If you click the "Searching these files" link it does show all the layout files though.

Comment 1

[Dave Miller [:justdave]]

This is probably because of bug 428104.  Cron jobs got aborted midway through
to recover the machine and there's probably partially-generated indexes sitting
around.  I'll re-run the mozilla tree manually right now.

Comment 3

[Dave Miller [:justdave]]

OK, the rebuild of the mozilla indexes has finished.

(In reply to comment #0)
> http://mxr.mozilla.org/mozilla/search?string=SetAttr(kNameSpace&find=&tree=mozilla
> 
> This gives "Found 15 matching lines in 5 files"
> But misses out the call in for example nsSliderFrame.cpp

Found 211 matching lines in 61 files

> Another example is
> http://mxr.mozilla.org/mozilla/search?string=SetAttr&find=layout&tree=mozilla
> Which isn't searching all files in layout. If you click the "Searching these
> files" link it does show all the layout files though.

Found 475 matching lines in 232 files

Looks like that one's fixed.

Rebuild of seamonkey (the one mentioned on the bug that got duped to this) is in progress now.

Comment 4

[Dave Miller [:justdave]]

(In reply to bug 428142 comment #0)
> e.g. these searches should return many hits, but they return none:
> http://mxr.mozilla.org/seamonkey/search?string=nscoord&find=%2Flayout%2Fbase&findi=&filter=.*cpp&hitlimit=&tree=seamonkey

Found 219 matching lines in 9 files

> http://mxr.mozilla.org/seamonkey/search?string=nscoord&find=&findi=&filter=&hitlimit=&tree=seamonkey

Too many hits, displaying the first 1000

> And this search for 'layout' in the full tree returns no matches from the
> layout directory -- only toolkit, tools, xpcom, and profile.
> 
> http://mxr.mozilla.org/seamonkey/search?string=layout&find=&findi=&filter=&hitlimit=&tree=seamonkey

Still don't see any in the layout directory, but this one also returned over 1000 hits, and it's quite possible they weren't in the first 1000.  There were many other things besides those 4 directory listed however.

Think this one's fixed for now. :)

Comment 5

[timeless]

http://mxr.mozilla.org/seamonkey/search?string=layout&find=mozilla%2Flayout%2F&findi=&filter=&hitlimit=&tree=seamonkey

returns over 1000 hits, but you can see they're all from the layout directory.

yes, this exposes an implementation detail which is arguably a problem, but oh well.