If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

test for bug 393970 fails on linux

RESOLVED FIXED in mozilla1.9

Status

()

Core
Layout
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Gavin, Assigned: Wladimir Palant)

Tracking

Trunk
mozilla1.9
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I had to disable it on Linux because it was failing on the linux tinderbox.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1207790179.1207793705.6466.gz&fulltext=1
(Assignee)

Comment 1

10 years ago
Experimenting with different font sizes on Windows, the testcase probably needs "description {min-width: 1px;}" added to its CSS. Otherwise the different intrinsic size of the grid cells seems to cause rounding errors (?).
(Assignee)

Comment 2

10 years ago
Created attachment 315468 [details] [diff] [review]
Proposed patch

Removed border from grid cells (was for testing only) and added min-width:1px instead - different intrinsic width seems to cause rounding errors. Tested, fixes the issue on Linux.
Assignee: nobody → trev.moz
Status: NEW → ASSIGNED
Attachment #315468 - Flags: superreview?(roc)
Attachment #315468 - Flags: review?(roc)
Attachment #315468 - Flags: superreview?(roc)
Attachment #315468 - Flags: superreview+
Attachment #315468 - Flags: review?(roc)
Attachment #315468 - Flags: review+
(Assignee)

Comment 3

10 years ago
Created attachment 315493 [details] [diff] [review]
Patch & Backout for Gavin's changes

Same patch as before plus backing out Gavin's changes disabling the testcase on Linux - it should work fine now.
Attachment #315468 - Attachment is obsolete: true
Attachment #315493 - Flags: superreview+
Attachment #315493 - Flags: review+
Attachment #315493 - Flags: approval1.9?
Comment on attachment 315493 [details] [diff] [review]
Patch & Backout for Gavin's changes

Test-only change, doesn't need approval.
Attachment #315493 - Flags: approval1.9?
Keywords: checkin-needed
mozilla/layout/xul/base/test/Makefile.in 	1.6
mozilla/layout/xul/base/test/test_bug393970.xul 	1.4
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in before you can comment on or make changes to this bug.