Closed
Bug 428226
Opened 16 years ago
Closed 16 years ago
test for bug 393970 fails on linux
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: Gavin, Assigned: jwkbugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.43 KB,
patch
|
jwkbugzilla
:
review+
jwkbugzilla
:
superreview+
|
Details | Diff | Splinter Review |
I had to disable it on Linux because it was failing on the linux tinderbox. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1207790179.1207793705.6466.gz&fulltext=1
|
Assignee | |
Comment 1•16 years ago
|
||
Experimenting with different font sizes on Windows, the testcase probably needs "description {min-width: 1px;}" added to its CSS. Otherwise the different intrinsic size of the grid cells seems to cause rounding errors (?).|
|
Assignee | |
Comment 2•16 years ago
|
||
Removed border from grid cells (was for testing only) and added min-width:1px instead - different intrinsic width seems to cause rounding errors. Tested, fixes the issue on Linux.
Assignee: nobody → trev.moz
Status: NEW → ASSIGNED
Attachment #315468 -
Flags: superreview?(roc)
Attachment #315468 -
Flags: review?(roc)
Attachment #315468 -
Flags: superreview?(roc)
Attachment #315468 -
Flags: superreview+
Attachment #315468 -
Flags: review?(roc)
Attachment #315468 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Same patch as before plus backing out Gavin's changes disabling the testcase on Linux - it should work fine now.
Attachment #315468 -
Attachment is obsolete: true
Attachment #315493 -
Flags: superreview+
Attachment #315493 -
Flags: review+
Attachment #315493 -
Flags: approval1.9?
|
Reporter | |
Comment 4•16 years ago
|
||
Comment on attachment 315493 [details] [diff] [review] Patch & Backout for Gavin's changes Test-only change, doesn't need approval.
Attachment #315493 -
Flags: approval1.9?
|
|
Reporter | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 5•16 years ago
|
||
mozilla/layout/xul/base/test/Makefile.in 1.6 mozilla/layout/xul/base/test/test_bug393970.xul 1.4
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in
before you can comment on or make changes to this bug.
Description
•