Closed Bug 428226 Opened 15 years ago Closed 15 years ago

test for bug 393970 fails on linux

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9

People

(Reporter: Gavin, Assigned: ecfbugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch & Backout for Gavin's changes
1.43 KB, patch
ecfbugzilla
: review+
ecfbugzilla
: superreview+
Details | Diff | Splinter Review 
I had to disable it on Linux because it was failing on the linux tinderbox.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1207790179.1207793705.6466.gz&fulltext=1
Experimenting with different font sizes on Windows, the testcase probably needs "description {min-width: 1px;}" added to its CSS. Otherwise the different intrinsic size of the grid cells seems to cause rounding errors (?).
Attached patch Proposed patch (obsolete) — — Splinter Review 
Removed border from grid cells (was for testing only) and added min-width:1px instead - different intrinsic width seems to cause rounding errors. Tested, fixes the issue on Linux.
Assignee: nobody → trev.moz
Status: NEW → ASSIGNED
Attachment #315468 - Flags: superreview?(roc)
Attachment #315468 - Flags: review?(roc)
Attachment #315468 - Flags: superreview?(roc)
Attachment #315468 - Flags: superreview+
Attachment #315468 - Flags: review?(roc)
Attachment #315468 - Flags: review+
Same patch as before plus backing out Gavin's changes disabling the testcase on Linux - it should work fine now.
Attachment #315468 - Attachment is obsolete: true
Attachment #315493 - Flags: superreview+
Attachment #315493 - Flags: review+
Attachment #315493 - Flags: approval1.9?
Comment on attachment 315493 [details] [diff] [review]
Patch & Backout for Gavin's changes

Test-only change, doesn't need approval.
Attachment #315493 - Flags: approval1.9?
mozilla/layout/xul/base/test/Makefile.in 	1.6
mozilla/layout/xul/base/test/test_bug393970.xul 	1.4
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in before you can comment on or make changes to this bug.