Closed
Bug 428276
Opened 16 years ago
Closed 15 years ago
Install button's tooltip worded incorrectly
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: ispence, Assigned: mkohler)
Details
Attachments
(2 files, 1 obsolete file)
16.50 KB,
image/png
|
Details | |
4.10 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
When I restarted Firefox after an nightly update, I was shown a dialog telling me Adblock had an update (dialog is attached). When I moused over the install button, I noticed the tooltip said "Installs the selected updates", which isn't correct wording. It should follow the format of the rest of the tooltips, making it "Install the selected updates"
Updated•16 years ago
|
Severity: normal → minor
Updated•16 years ago
|
Product: Firefox → Toolkit
Updated•15 years ago
|
Whiteboard: [good first bug]
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → michaelkohler
Severity: minor → trivial
OS: Linux → All
Hardware: x86 → All
Whiteboard: [good first bug]
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #380188 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Attachment #380188 -
Flags: review? → review?(dtownsend)
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Updated•15 years ago
|
Attachment #380188 -
Flags: review?(dtownsend) → review+
Comment 2•15 years ago
|
||
Comment on attachment 380188 [details] [diff] [review] one-liner Actually we should be safe and change the entity name too
Attachment #380188 -
Flags: review+ → review-
Updated•15 years ago
|
Attachment #380188 -
Flags: review- → review?
Updated•15 years ago
|
Attachment #380188 -
Flags: review? → review-
Comment 3•15 years ago
|
||
Comment on attachment 380188 [details] [diff] [review] one-liner Ok you need to rename cmd.installUpdatesAll.* to cmd.installUpdatesAll2.*, both here and in the XUL
Assignee | ||
Comment 4•15 years ago
|
||
* changes cmd.installUpdatesAll.* to cmd.installUpdatesAll2.*
Attachment #380188 -
Attachment is obsolete: true
Attachment #380193 -
Flags: review?(dtownsend)
Comment 5•15 years ago
|
||
Comment on attachment 380193 [details] [diff] [review] v2 [Checkin: Comment 6] Thanks
Attachment #380193 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [not for 1.9.1, so checkin as recently as the restriction is gone]
Comment 6•15 years ago
|
||
Comment on attachment 380193 [details] [diff] [review] v2 [Checkin: Comment 6] http://hg.mozilla.org/mozilla-central/rev/d325ad42d391
Attachment #380193 -
Attachment description: v2 → v2
[Checkin: Comment 6]
Comment 7•15 years ago
|
||
I think a 1.9.1 patch with the extra 's' removal only would be fine for en-US, would it not?
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [not for 1.9.1, so checkin as recently as the restriction is gone]
Target Milestone: --- → mozilla1.9.2a1
Comment 8•15 years ago
|
||
Axel's call really, I think we refrain from doing it though.
Comment 9•15 years ago
|
||
Actually, in this case we shouldn't have rev'ed the key, IMHO. Just CCing the folks that have the original string would have sufficed. A non-key-changing patch would be OK for 1.9.1.x, I wouldn't necessarily land it for 3.5.0, though.
Comment 10•15 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090908 Minefield/3.7a1pre ID:20090908030622 and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090908 Namoroka/3.6a2pre ID:20090908033627
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•