428326 - Configuring with a relative srcdir breaks unit tests in XPCOM

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Benjamin Smedberg]

Attachment: Use the absolute srcdir, rev. 1

Configuring with a relative srcdir (e.g. ../src/configure) breaks unit tests in XPCOM. This is because we end up passing $(srcdir) to a binary which tries to initialize an nsIFile with it, and nsIFile can only be initialized with an absolute path. easy, though not especially pretty fix attached.

This is a regression from the tests of bug 416886 and I'd like to get it landed in CVS for 1.9

Comment 1

[Benjamin Smedberg]

Comment on attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

Very low-risk test-only code.

Comment 2

[Mark Smith [:mcs]]

This fix also looks OK to me (I helped brade with the Makefile changes for bug 416886).  Maybe you want to leave the leading @ on this line though?

   @rm -f $(DIST)/bin/components/compreg.dat; \

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

a1.9=beltzner

Comment 4

[Benjamin Smedberg]

Fixed in CVS (had already pushed this to mozilla-central).