Closed Bug 428326 Opened 14 years ago Closed 14 years ago

Configuring with a relative srcdir breaks unit tests in XPCOM

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

Configuring with a relative srcdir (e.g. ../src/configure) breaks unit tests in XPCOM. This is because we end up passing $(srcdir) to a binary which tries to initialize an nsIFile with it, and nsIFile can only be initialized with an absolute path. easy, though not especially pretty fix attached.

This is a regression from the tests of bug 416886 and I'd like to get it landed in CVS for 1.9
Attachment #314863 - Flags: review?(ted.mielczarek)
Attachment #314863 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

Very low-risk test-only code.
Attachment #314863 - Flags: approval1.9?
This fix also looks OK to me (I helped brade with the Makefile changes for bug 416886).  Maybe you want to leave the leading @ on this line though?

   @rm -f $(DIST)/bin/components/compreg.dat; \
Comment on attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

a1.9=beltzner
Attachment #314863 - Flags: approval1.9? → approval1.9+
Fixed in CVS (had already pushed this to mozilla-central).
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in before you can comment on or make changes to this bug.