Configuring with a relative srcdir breaks unit tests in XPCOM

RESOLVED FIXED in mozilla1.9

Status

()

Core
XPCOM
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

unspecified
mozilla1.9
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

Configuring with a relative srcdir (e.g. ../src/configure) breaks unit tests in XPCOM. This is because we end up passing $(srcdir) to a binary which tries to initialize an nsIFile with it, and nsIFile can only be initialized with an absolute path. easy, though not especially pretty fix attached.

This is a regression from the tests of bug 416886 and I'd like to get it landed in CVS for 1.9
Attachment #314863 - Flags: review?(ted.mielczarek)
Attachment #314863 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 1

10 years ago
Comment on attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

Very low-risk test-only code.
Attachment #314863 - Flags: approval1.9?

Comment 2

10 years ago
This fix also looks OK to me (I helped brade with the Makefile changes for bug 416886).  Maybe you want to leave the leading @ on this line though?

   @rm -f $(DIST)/bin/components/compreg.dat; \
Comment on attachment 314863 [details] [diff] [review]
Use the absolute srcdir, rev. 1

a1.9=beltzner
Attachment #314863 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 4

10 years ago
Fixed in CVS (had already pushed this to mozilla-central).
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in before you can comment on or make changes to this bug.