428370 - Sync Browser Preferences

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P2)

Description

[Jaime Mitchell (use [e-mail] for email)]

Weave should Sync all browser preferences (including those for extensions).

Ideally it should be careful of the following:
o Preferences which might need to be different on different platforms (as user could be syncing data between different platform versions of firefox)
o Preferences which change between versions (user might be running stable firefox release on one machine such as a work machine and nightly build on another such as home pc)

Comment 1

[Dan Mills [:thunder]]

Targeting for 0.3.

This is trickier than it sounds, because not all preferences should be synced.  We'll need to whitelist which prefs are OK to sync, as well as create an API for extensions to manipulate that whitelist.

Comment 2

[Dan Mills [:thunder]]

These bugs need to be triaged, removing 0.3 milestone setting.

Comment 3

[Anant Narayanan [:anant]]

Attachment: Preference Sync (v1)

Adds preference sync support. We sync all preferences listed under the branch "extensions.weave.prefs.sync" in one WBO (with a fixed GUID). The default client-wins behavior as provided by Engine is used.

Deafult set of preferences to be synced are listed in defaults/preferences/sync.js. I just added a random set - needs to be refined to a set of actually useful ones.

Comment 4

[Anant Narayanan [:anant]]

Few preferences I think should be synced by default:

signon.rememberSignons
browser.startup.homepage
startup.homepage_override_url
browser.tabs.warnOnClose
browser.search.selectedEngine
spellchecker.dictionary

Comment 5

[Dan Mills [:thunder]]

Sounds like a good initial set.

Why not make the "guid" some human-readable string, like "prefs" or somesuch?  There's no point in hardcoding an actual guid.

I didn't read it very carefully, but it looks good.  I'd ask for tests, but we don't have good ways of making tests for sync engines :-/  Can you file a follow-up bug for that and take a stab at an initial implementation?

Otherwise I'd say commit it so others can test it.

Comment 6

[Anant Narayanan [:anant]]

Committed: http://hg.mozilla.org/labs/weave/rev/2e090a4d1277
Bug #494635 filed for sync engine testing.

Comment 7

[Ayan Shah[:ashah]]

Investigating this bug for being potential crossweave automation test case
candidate.