Closed Bug 428371 Opened 12 years ago Closed 11 years ago

"Search Foo for selected text" context menu hitchhikes an accesskey

Categories

(Firefox :: Menus, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.1a2

People

(Reporter: rimas, Assigned: wladow)

References

()

Details

(Keywords: intl)

Attachments

(2 files)

Attached image Screenshot
In http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/browser/browser.dtd#113, an entity search.accesskey is defined as an accesskey for the main menu item defined in a previous line (Tools > Web Search).

Apparently, in http://lxr.mozilla.org/mozilla/source/browser/base/content/browser-context.inc#181 the same entity is hitchhiked for a completely different purpose – it's used for a context menu item that only appears when some text is selected and right-clicked. That context menu entry is completely different from the one above, e.g. "Search Google for selected text". It MUST have its own accesskey, otherwise it creates a localization problem (see screenshot)
OS: Linux → All
Hardware: PC → All
Flags: blocking-firefox3?
Keywords: intl
Regarding Jesse's blocking request, this is unfortunate, but I don't see us fixing this anymore.
Blocks: 428463
This has been the case since Firefox 1.0, agree that we should fix, but not going to break string freeze at this time.
Flags: blocking-firefox3? → blocking-firefox3-
Attached patch v1Splinter Review
Use separate accesskey for context-searchselect menuitem
Assignee: nobody → wladow
Status: NEW → ASSIGNED
Attachment #331094 - Flags: review?(gavin.sharp)
Attachment #331094 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/index.cgi/mozilla-central/rev/6ca2dcafc383
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
You need to log in before you can comment on or make changes to this bug.