428411 - Can't drag and drop to "bookmarks toolbar" menuitem in bookmarks menu (should open on drag over)

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Damian Shaw [Quan]]

1. Open Bookmark Menu
2. Drag and drop a bookmark over the "bookmark toolbar" menu
3. "bookmark toolbar" menu does not pop open

Very inconsistent behavior, feasibly someone could want to do this when the bookmark toolbar isn't open.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

WFM 
Dragging a URL from the Awesomebar onto the Menu bar - the Bookmarks menu opens
Opening the Bookmark Sidebar with the Bookmarks Toolbar 'collapsed' hovering over the 'twistie' + the Toolbar menu opens 

Do you have steps to repo?

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041005 Minefield/3.0pre Firefox/3.0 ID:2008041005

Comment 2

[Damian Shaw [Quan]]

(In reply to comment #1)
> WFM 
> Dragging a URL from the Awesomebar onto the Menu bar - the Bookmarks menu opens
> Opening the Bookmark Sidebar with the Bookmarks Toolbar 'collapsed' hovering
> over the 'twistie' + the Toolbar menu opens 
> 
> Do you have steps to repo?
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041005
> Minefield/3.0pre Firefox/3.0 ID:2008041005
> 

Huh? I think I must of explained myself really badly, I didn't mean any of that.

Simply:

1) Click on Bookmarks (in between History and Tools on the Menu bar).

2) Hover over a bookmark

3) Drag and drop the bookmark upwards to the fixed element in the Bookmark Menu "Bookmark Toolbar       >"

4) The "Bookmark Toolbar       >" does not pop open.

Expected behavior, would be that it popped open, it's very inconsistent with the rest of the Bookmark menu.

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

oops, sorry - did misunderstand, your right the Bookmarks Toolbar menu does not open like other folders.  

IIRC that was just recently re-added to the Bookmarks Menu drop-list. 
(that being the Bookmarks Toolbar)

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Marco, I think you may have caused this inadvertantly.

Doesn't block, but only by virtue of the fact that you can still drag a bookmark from that menu onto the Bookmark Toolbar itself as a workaround. Definitely wanted, though, as the inconsistency kinda sucks :)

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #5)
> Marco, I think you may have caused this inadvertantly.

when? bookmarks toolbar menu item is very different from other items there, since it's a static item, so its "hover" state should not be controlled by the view. Has probably to be workarounded with a dedicated timer, or hacked to be controlled by menu view.

Comment 7

[Max Karl Ernst]

Stupid question - why is it special/different? Why wasn't it just made as a normal query item that is movable and deletable and "drag&dropable"? :) I really don't see the reason to add special exceptions all over the UI.

Comment 8

[Damian Shaw [Quan]]

(In reply to comment #7)
> Stupid question - why is it special/different? Why wasn't it just made as a
> normal query item that is movable and deletable and "drag&dropable"? :) I
> really don't see the reason to add special exceptions all over the UI.
> 

That got me thinking a bit about why with the whole SQLite stuff why you simply don't have a query, like Most Visited or Recent Tags. So I've been playing about with it a bit and the answer has become fairly obvious.

Any action you do in "Bookmarks Toolbar" menu gets instantly duplicated in the bookmark toolbar. Which actually makes sense to have a special item to do this. But in which case it makes even more sense to get this and bug 429392 fixed.

Comment 9

[Daniel.S]

(In reply to comment #8)
> Any action you do in "Bookmarks Toolbar" menu gets instantly duplicated in the
> bookmark toolbar.

I'm not sure if that's what you mean, but if I drag an item onto the Bookmarks Toolbar menu item, it gets duplicated at the first position of the main Bookmarks Menu.

Comment 10

[Damian Shaw [Quan]]

Would be nice to have consistent behaviour for 3.1, any chance?

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marco, it looks like that there is no update for this bug and Firefox 3.1?

Comment 13

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yep, bug still there.

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 15

[Damian Shaw [Quan]]

I'm confused, this still very much affects the trunk. Just confirmed on:

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.3a1pre) Gecko/20091211 Minefield/3.7a1pre

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See the Bugzilla docs for more information and exactly that way it is handled for the Firefox product.

"Versions are the revisions of the product, such as "Flinders 3.1", "Flinders 95", and "Flinders 2000". Version is not a multi-select field; the usual practice is to select the earliest version known to have the bug."

Comment 17

[Mihaela Velimiroviciu (:mihaelav)]

The issue is still reproducible on 3.6.25 as described in comment #0.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.25) Gecko/20111212 Firefox/3.6.25

Comment 18

[krichter]

This is still an issue in 33.0. The possibilities to add items to the bookmark toolbar are generally poor. I didn't manage to run any of the following actions (which I'll address in seperate bug reports after this first one is fixed):

  * Drag&Drop from Bookmark menu should be possible from any menu item and menu to the toolbar (menu item should be represented as folders because that make sense) (addressed in the report)
  * Drag&Drop within the bookmarks toolbar (it should be possible to arrange bookmarks in folders added to the toolbar)
  * Drag&Drop withing the bookmark menu (outside the bookmark toolbar) doesn't work as well

The length of the incomplete list of issues facing Drag&Drop in conjunction with bookmarks makes me wonder whethere this issue should not only be reactivated but also integrated in a larger issue regarding Drag&Drop facilities in general as well.

Comment 19

[Mark Banner (:standard8)]

I've just tested the steps in comment 2 with Firefox 59.0.2 on Windows 10. Drag & drop works fine to and from the toolbar folder within the bookmarks menu. Other cases seem to work fine as well.