Closed Bug 428422 Opened 14 years ago Closed 14 years ago

setItemTitle does not need to do 2 queries

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: mak, Assigned: mak)

Details

(Keywords: perf)

Attachments

(1 file)

Attached patch patchSplinter Review
getItemTitle can update lastModified in the same query where it updated title. So no need for a function call, a second query and a transaction.
Low risk perf fix.
Attachment #314986 - Flags: review?(dietrich)
Assignee: nobody → mak77
Summary: getItemTitle does not need to do 2 queries → setItemTitle does not need to do 2 queries
Status: NEW → ASSIGNED
i mean setItemTitle
Attachment #314986 - Flags: review?(dietrich) → review+
Comment on attachment 314986 [details] [diff] [review]
patch

drivers: a simple perf fix i found while working on another bug.
Attachment #314986 - Flags: approval1.9?
Comment on attachment 314986 [details] [diff] [review]
patch

a1.9=beltzner
Attachment #314986 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 	1.163
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.