Closed Bug 428431 Opened 12 years ago Closed 12 years ago

configure should add -wd flags to CFLAGS/CXXFLAGS for PGO builds

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: mikeal, Assigned: ted)

Details

Attachments

(1 file)

The PGO box started burning recently.

Ted tracked the issue to some missing env variables in the build config.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/tools/tinderbox-configs/firefox/win32&command=DIFF_FRAMESET&file=mozconfig&rev2=1.21&rev1=1.20

The previous changeset needs to get migrated to all pgo build configs.
Actually I want to do this in configure, not mozconfigs, but thanks for filing!
OS: Mac OS X → Windows XP
Summary: All PGO configs need CFLAGS set properly in their buildconfig → configure should add -wd flags to CFLAGS/CXXFLAGS for PGO builds
Trivial patch, adds these warning disable flags when building with PGO.
Attachment #316416 - Flags: review?(benjamin)
Attachment #316416 - Flags: review?(benjamin) → review+
Comment on attachment 316416 [details] [diff] [review]
add the -wd flags to PROFILE_USE_CFLAGS

Seriously low risk, the tinderboxes already use these CFLAGS/CXXFLAGS for buliding PGO, this will just help other people avoid build bustage.
Attachment #316416 - Flags: approval1.9?
Comment on attachment 316416 [details] [diff] [review]
add the -wd flags to PROFILE_USE_CFLAGS

a1.9+=damons
Attachment #316416 - Flags: approval1.9? → approval1.9+
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1986; previous revision: 1.1985
done

Should probably get these flags out of the mozconfig files now, just to keep them free of extraneous cruft.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Version: unspecified → Trunk
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.