42850 - JavaScript error in Prefs window

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[J Laramie]

I get a JavaScript error when I open up the Preferances. Can't destroy it
afterwards either.

WEBSHELL- = 13
*** window.arguments not found, defaulting to navigator panel
WEBSHELL+ = 14
JavaScript error:
chrome://communicator/content/pref/nsPrefWindow.js line 81: window.arguments has
no properties

JavaScript error:
chrome://communicator/content/pref/nsPrefWindow.js line 35: aPageTag is not defined

JavaScript error:
chrome://communicator/content/pref/nsPrefWindow.js line 89: hPrefWindow has no
properties

(I get this when I click on OK) ^^

JavaScript error:
chrome://communicator/content/pref/nsPrefWindow.js line 107: hPrefWindow has no
properties


(I get this when I click on Cancel) ^^

Comment 1

[lchiang]

reassign to prefs area.

Comment 2

[lchiang]

reassign to owner of default component.

Comment 3

[Alec Flett]

CC ben since he actually wrote this.

Comment 4

[Cyril Bortolato]

When I go to Edit->Preferences with 2000-06-16-11 on Linux, I don't get
the errors you report, but rather:

we don't handle eBorderStyle_close yet... please fix me
WEBSHELL+ = 5
*** panel to load is = chrome://communicator/content/pref/pref-navigator.xul
WEBSHELL+ = 6
*** running closeBranches
*** foopy = true


Reporter, which build are you using?

Comment 5

[J Laramie]

Build ID: 2000061311

Comment 6

[sairuh (rarely reading bugmail)]

over to ben...

Comment 7

[Decklin Foster]

Attachment: patch to fix it

Comment 8

[sairuh (rarely reading bugmail)]

added patch kw --ben or alecf, could either of you review this for checkin? thx!

Comment 9

[Alec Flett]

hrm.. I was going to but I don't know the prefwindow code that well. Let me try
today's build with the patch and see what my results are.

Comment 10

[Decklin Foster]

*** Bug 43416 has been marked as a duplicate of this bug. ***

Comment 11

[Alec Flett]

ok, this looks good to me. Get approval from [e-mail] or 
[e-mail] and I'll check it in.

Comment 12

[Decklin Foster]

Actually Ben made a better fix (see blake's comments on bug 43190), and it's in
062208. marking.

Comment 13

[sairuh (rarely reading bugmail)]

vrfy per above comments. :)