428579 - "You have added a security exception for this site " lacks a final dot

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

http://mxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/browser.properties#113

"You have added a security exception for this site" lacks the final dot at the end of the sentence. It is displayed next to strings that do have a final dot so it is very minor but visible. Not so important, but it would be nice to fix that in the future.

Comment 1

[Shlomi Fish]

->Pascalc: excuse me, but can you tell me where is this string displayed exactly? Which operations do I need to perform to invoke it?

Comment 2

[u88484]

Pascalc:  Can you give us steps so we can see this dialog?

Comment 3

[Shlomi Fish]

->Pascalc: ping. Please answer.

Comment 4

[leftturnsolutions]

Attachment: Punctuation correction for en-US browser property: identity.identified.verified_by_you

I know this is a small patch, but it is my first so I was hoping a simple issue such as this would serve as an introduction to the process. This issue could be seen by visiting an https:// site with an invalid certificate (https://webre.education.ucsb.edu/ was used in my testing). Add a security exception for the site, then hover the ucsb.edu to the left of the location bar. Prior to this patch there is no ending ".". I did a grep through the code base and it appeared this was the only location this property was used. If dietrich is not the appropriate reviewer please let me know, I just grabbed the last name off the MXR logs.

Comment 5

[Shlomi Fish]

(In reply to comment #4)
> Created an attachment (id=379510) [details]
> Punctuation correction for en-US browser property:
> identity.identified.verified_by_you
> 
> I know this is a small patch, but it is my first so I was hoping a simple issue
> such as this would serve as an introduction to the process. This issue could be
> seen by visiting an https:// site with an invalid certificate
> (https://webre.education.ucsb.edu/ was used in my testing). Add a security
> exception for the site, then hover the ucsb.edu to the left of the location
> bar. Prior to this patch there is no ending ".". I did a grep through the code
> base and it appeared this was the only location this property was used. If
> dietrich is not the appropriate reviewer please let me know, I just grabbed the
> last name off the MXR logs.

Can confirm here. One needs to hover over the icon at the left of the location bar. Indeed there is no dot / period. Thanks for finding it!

Regards,

      Shlomi Fish

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 379510 [details] [diff] [review]
Punctuation correction for en-US browser property: identity.identified.verified_by_you

r=me, thanks for fixing this!

unfortunately, it's too late for string changes to Firefox 3.5. however, the fix will make the next version after that.

Comment 7

[Axel Hecht [:Pike]]

Looking at fennec, this needs a corresponding fix in fennec.

Mind doing a quick shout out in m.d.l10n to make localizers see this? http://mxr.mozilla.org/l10n-mozilla1.9.1/search?string=identity.identified.verified_by_you&find=browser.properties&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla1.9.1 shows that a bunch of locales have this. Despite the popularity of that mistake, this doesn't require a key change in en-US though.

Comment 8

[leftturnsolutions]

Sure thing, I'll join the list and send a shout.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/70e11ec1f35a