428733 - add better error handling in AddVisit

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

Attachment: fix

sdwilsh caught this while testing another bug.

Comment 1

[Shawn Wilsher :sdwilsh]

basically, we assume that it was already in the db, but upon failure of ExecuteStep, we'd still be assuming it was in the db and try to get information from the statement.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 315325 [details] [diff] [review]
fix

r=mano

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 315325 [details] [diff] [review]
fix

drivers: very low risk fix to catch potential underlying db errors.

Comment 4

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.291; previous revision: 1.290
done

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv