Closed Bug 428733 Opened 14 years ago Closed 14 years ago

add better error handling in AddVisit

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: dietrich, Unassigned)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
sdwilsh caught this while testing another bug.
Attachment #315325 - Flags: review?(mano)
basically, we assume that it was already in the db, but upon failure of ExecuteStep, we'd still be assuming it was in the db and try to get information from the statement.
Comment on attachment 315325 [details] [diff] [review]
fix

drivers: very low risk fix to catch potential underlying db errors.
Attachment #315325 - Flags: approval1.9?
Attachment #315325 - Flags: approval1.9? → approval1.9+
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.291; previous revision: 1.290
done
Status: NEW → RESOLVED
Closed: 14 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.