428803 - In <pageinfo/security.js> (Line: 315), "Warning: reference to undefined property Components.classes['@mozilla.org/login-manager;1']"

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041204 Minefield/3.0pre] (FX-WIN32-TBOX-trunk) (W2Ksp4)

No bug.


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b4pre) Gecko/2008022702 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

{{
Warning: reference to undefined property Components.classes['@mozilla.org/login-manager;1']
Source File: chrome://navigator/content/pageinfo/security.js
Line: 315
}}

This looks similar to Calendar bug 412723...

Comment 1

[Serge Gautherie (:sgautherie)]

Steps:
1. Load <about:>, for example.
2. Context menu > View Page Info.

Comment 2

[Serge Gautherie (:sgautherie)]

<http://mxr.mozilla.org/seamonkey/search?string=login-manager%3B1&case=on&tree=seamonkey>
{{
/suite/browser/pageinfo/security.js
    * line 328 -- var passwordManager = Components.classes["@mozilla.org/login-manager;1"]

/suite/modules/test/browser_sanitizer.js
    * line 193 -- this.pm = Components.classes["@mozilla.org/login-manager;1"]

/suite/modules/Sanitizer.jsm
    * line 230 -- var pwmgr = Components.classes["@mozilla.org/login-manager;1"]
    * line 239 -- var pwmgr = Components.classes["@mozilla.org/login-manager;1"]
}}

Only the first one is not commented out by
{{
/* XXX: commented out as long as we aren't using toolkit's login manager
}}

Comment 3

[[e-mail]]

I probably failed to notice because I tested page info on a build which also has login manager "enabled".

Since we're planning on implementing login manager for 2.0a1 this bug may well become WONTFIX.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <security.js> Comment out future code [Checkin: Comment 6]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008051002 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

"Wallpaper", in the meantime, as elsewhere.

Comment 5

[Daniel Brooks [:db48x]]

Comment on attachment 320397 [details] [diff] [review]
(Av1) <security.js> Comment out future code
[Checkin: Comment 6]

Yea, r=db48x

Comment 6

[Daniel Brooks [:db48x]]

checked in

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008051402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed

Comment 8

[Robert Kaiser]

Could you please add a patch for reverting this again to bug 390025 so we don't miss it when that one can go in (which is an alpha blocker)?

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> Could you please add a patch for reverting this again to bug 390025 so we don't

Done: bug 390025 comment 28.