Closed
Bug 428846
Opened 16 years ago
Closed 16 years ago
Using underline hint at painting the strikeout line of Quirks mode
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
Details
(Keywords: regression)
Attachments
(1 file)
1.26 KB,
patch
|
roc
:
review+
roc
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
This is my mistake. At quriks mode, the strikeout line painting code put the wrong hint to nsCSSRendering::PaintDecorationLine(). By this bug, the strikeout line is lowered half of the decoration line height from the correct position.
Attachment #315412 -
Flags: superreview?(roc)
Attachment #315412 -
Flags: review?(roc)
Attachment #315412 -
Flags: superreview?(roc)
Attachment #315412 -
Flags: superreview+
Attachment #315412 -
Flags: review?(roc)
Attachment #315412 -
Flags: review+
Assignee | ||
Comment 1•16 years ago
|
||
Comment on attachment 315412 [details] [diff] [review] fix This is a simple mistake. And the strikeout line of Quirks mode is lowered some pixels than Standards mode. Especially, when the font-size is very large.
Attachment #315412 -
Flags: approval1.9?
Comment 2•16 years ago
|
||
Possible to add a reftest for this?
Assignee | ||
Comment 3•16 years ago
|
||
(In reply to comment #2) > Possible to add a reftest for this? I have no idea for reftest...
Comment 4•16 years ago
|
||
Comment on attachment 315412 [details] [diff] [review] fix a1.9=beltzner
Attachment #315412 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 5•16 years ago
|
||
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•