Closed Bug 428846 Opened 13 years ago Closed 13 years ago

Using underline hint at painting the strikeout line of Quirks mode

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch fixSplinter Review
This is my mistake.

At quriks mode, the strikeout line painting code put the wrong hint to nsCSSRendering::PaintDecorationLine(). By this bug, the strikeout line is lowered half of the decoration line height from the correct position.
Attachment #315412 - Flags: superreview?(roc)
Attachment #315412 - Flags: review?(roc)
Attachment #315412 - Flags: superreview?(roc)
Attachment #315412 - Flags: superreview+
Attachment #315412 - Flags: review?(roc)
Attachment #315412 - Flags: review+
Comment on attachment 315412 [details] [diff] [review]
fix

This is a simple mistake.

And the strikeout line of Quirks mode is lowered some pixels than Standards mode. Especially, when the font-size is very large.
Attachment #315412 - Flags: approval1.9?
Possible to add a reftest for this?
(In reply to comment #2)
> Possible to add a reftest for this?

I have no idea for reftest...
Comment on attachment 315412 [details] [diff] [review]
fix

a1.9=beltzner
Attachment #315412 - Flags: approval1.9? → approval1.9+
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.