Closed Bug 428973 Opened 12 years ago Closed 11 years ago

Rewrite Mac OS X default plugin for 64-bit

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 2 obsolete files)

15.73 KB, application/octet-stream
Details
85.71 KB, patch
Details | Diff | Splinter Review
We're going to need to rewrite our default plugin for Mac OS X for 64-bit. The following changes need to be made:
- Use the CoreGraphics NPAPI drawing model
- Remove all Quickdraw/Carbon usage, use only CoreGraphics, CoreFoundation, and Cocoa
- Get rid of resource file usage, use plist and image files instead

We'll probably only need to support Mac OS X 10.5 and up on x86 and x86-64. This work should be done for Mozilla 2.
Attached patch fix v0.2 (obsolete) — Splinter Review
I've messed around with this before, backing up the patch here. This won't compile or run, it is just a start.
When I did this I did it to figure out what problems we're going to have with NPAPI. The big one is that our current NPAPI event model on Mac OS X is based on Carbon, and that stuff doesn't exist in 64-bit Mac OS X. We need to spec out a new event model, probably offer it for negotiation on 32-bit and make it mandatory on 64-bit. That is being worked on.
Depends on: 435041
Attached file fix v1.0 (obsolete) —
This is a zip file containing a new default plugin. It is *way* simpler, written using current best-practices and it doesn't include any of that old Netscape plugin finder stuff.
Attachment #315575 - Attachment is obsolete: true
All the new plugin does is draw a thin blue border around a white background and paint the broken-plugin image in the center of the plugin rect. Do we need to do anything else?
Attached file fix v1.1
Forgot to clean up a couple of things.
Attachment #344359 - Attachment is obsolete: true
Attached patch fix v1.1 (patch)Splinter Review
This is a patch that integrates fix v1.1 into our tree. There are changes from the "fix v1.1" zip file but they are build changes only.

This has sr+ from jst.
landed on trunk
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Looks like this has compile problems on 10.4 and busted the SeaMonkey mac builder, see http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225307530.1225310208.32734.gz#err0
landed a fix, we shouldn't have been explicitly targeting the 10.5 sdk
You need to log in before you can comment on or make changes to this bug.