Closed
Bug 428980
Opened 16 years ago
Closed 16 years ago
leaking NSAutoreleasePool object in insertText
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: masayuki, Assigned: masayuki)
Details
(Keywords: memory-leak, regression)
Attachments
(1 file)
1.82 KB,
patch
|
jaas
:
review+
vlad
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
This is my fault. NSAutoreleasePool is now leaking at every enter key pressing! And that is not need here, because that was already created by event loop. So, we don't need to create that ourselves. (The code was written by me, sorry) This leaking is occurred on chatzilla at very very many time. So, we must fix this on Gecko1.9. They should be just removed.
Flags: blocking1.9?
Attachment #315580 -
Flags: review?(joshmoz)
Attachment #315580 -
Flags: review?(joshmoz) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #315580 -
Flags: superreview?(vladimir)
Updated•16 years ago
|
Flags: blocking1.9? → blocking1.9+
Whiteboard: [needs review vlad]
Attachment #315580 -
Flags: superreview?(vladimir) → superreview+
Assignee | ||
Comment 1•16 years ago
|
||
Comment on attachment 315580 [details] [diff] [review] Patch v1.0 Let's take this. This leaks the memory every Enter key pressing.
Attachment #315580 -
Flags: approval1.9?
Comment 2•16 years ago
|
||
Comment on attachment 315580 [details] [diff] [review] Patch v1.0 a1.9=beltzner
Attachment #315580 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 3•16 years ago
|
||
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [needs review vlad]
You need to log in
before you can comment on or make changes to this bug.
Description
•