run dehydra unit tests with 'make check' and integrate them with configure

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
9 months ago

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 315784 [details] [diff] [review]
make check for dehydra, rev. 1

This patch integrates the dehydra unit tests with configure, and runs them using 'make check' from the root directory. You can run the treehydra unit tests with 'make check_treehydra' and I've also added a convenience target 'make treehydra' to make gcc_treehydra.so.
Attachment #315784 - Flags: review?(dmandelin)

Comment 1

11 years ago
I think it's more appropriate to make ./configure look for the installed g++ and use that. I'm pretty sure if you just build gcc and don't make install it, g++ wont even be able to find the correct headers when you compile stuff.

Also, would be nice to have make gcc_treehydra.so be the correct target. While at it, perhaps we should just do ./configure --enable-treehydra instead of the makefile hacks. Then there will be only make check, instead of having treehydra varieties of everything.

(Assignee)

Comment 2

11 years ago
got r=taras on IRC. Pushed. I'll do --enable-treehydra as a seprate followup.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Attachment #315784 - Flags: review?(dmandelin)

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.