429257 - AwesomeBar refactoring

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aleks Totic]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: 

I've refactored the awesomeBar into an overlay. I tried to minimize the differences. The basic idea was:
- move all awesomeBar commands & UI into an overlay
- remove all references to LocationBar from browser code
  to do this, i had to create new events by progressController, endNetwork/startNetwork/locationUpdate

This will allow us to overlay different awesomeBar implementations. I did not know how to make svn spit out the diffs for files not under svn control, so I checked in awesomeToolbar.xul/js.


Reproducible: Always

Comment 1

[Aleks Totic]

Attachment: Patch to refactor out the awesome bar

This takes out Bookmarks & LocationBar out of browser.js/xul
The code moves to awesomeToolbar.js/xul, which are already checked in.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Looks like this patch no longer applies?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Some of this was already done before we moved to Hg. Let's file new bugs for any future refactors

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

yeah, this is old and awesome bar is working great.