Open Bug 429272 Opened 12 years ago Updated 11 months ago

stop pretending to build with glib1

Categories

(Firefox Build System :: General, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

People

(Reporter: vlad, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

We have configure checks that do AM_PATH_GLIB if MOZ_ENABLE_GTK2 isn't set -- do we need this any more?  Does the win32 build still use glib1?  This causes breakage if you try to build on linux with something other than gtk2.  The attached patch just has us do a normal PKG_CHECK_MODULES for glib2 always.
Attachment #315924 - Flags: review?(benjamin)
Attachment #315924 - Flags: review?(benjamin) → review+
Adding needs-checkin for checkin after tree opens post-1.9
Whiteboard: needs-checkin
The previous patch would've killed win32 builds; GLIB_CFLAGS and friends are explicitly specified by configure for those platforms, to pick up the mozilla-tools versions.  So put back the -z check for preexisting GLIB_CFLAGS/GLIB_LIBS.
Assignee: nobody → vladimir
Attachment #315924 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #323830 - Flags: review?(benjamin)
Attachment #323830 - Flags: review?(benjamin) → review+
Whiteboard: needs-checkin → checkin-needed
Vlad, are you going to check this in?
Hm, yes, I should; I think last time I tried to confirm the patch works the tryserver was down or something.  Will do it this week.
Removing 'checkin-needed' because it looks like Vlad wanted to do something here.
Whiteboard: checkin-needed
Comment on attachment 315924 [details] [diff] [review]
get rid of AM_PATH_GLIB
[Backout: See comment 8]


A reduced version of this patch was checked in as part of
http://hg.mozilla.org/mozilla-central/rev/93c820a60cb1
Fix compilation in qgeckoglobals.cpp; also fix 429272
Attachment #315924 - Attachment description: get rid of AM_PATH_GLIB → get rid of AM_PATH_GLIB [Checkin: See comment 7]
Attachment #315924 - Attachment is obsolete: false
Comment on attachment 315924 [details] [diff] [review]
get rid of AM_PATH_GLIB
[Backout: See comment 8]


(In reply to comment #7)
> A reduced version of this patch was checked in as part of

But was reverted as part of:
http://hg.mozilla.org/mozilla-central/rev/10b845068cff
Merging mozilla-central to mozilla-qt.

Oh well :-< Sorry.
Attachment #315924 - Attachment description: get rid of AM_PATH_GLIB [Checkin: See comment 7] → get rid of AM_PATH_GLIB [Backout: See comment 8]
Attachment #315924 - Attachment is obsolete: true
Assignee: vladimir → nobody
Product: Core → Firefox Build System
No assignee, updating the status.
Status: ASSIGNED → NEW
No assignee, updating the status.
No assignee, updating the status.
No assignee, updating the status.
You need to log in before you can comment on or make changes to this bug.