429273 - Pre-3.2 image-preview link pages are missing their images

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Pre-3.2 image-preview link pages are missing their images

There are still pre-3.2-style image-preview links out there, such as the one on Philip's page at http://xsidebar.mozdev.org/modifiedmisc.html#executejs, which points to https://addons.mozilla.org/addons/previews/1729.  

For the 3.2 reskin, we changed the URL/path structure (because of the lightbox?), so the link should actually be https://addons.mozilla.org/en-US/firefox/images/preview/1729/1

Not sure if we should:

1) Do something with (i.e. fix/populate) https://addons.mozilla.org/addons/previews/1729 with the preview images (and fix its style), -or-
2) Put a 302 or something on this page and redirect to https://addons.mozilla.org/en-US/firefox/images/preview/1729/1

As far as I can tell, nothing in the in-page 3.2 experience links to the old style, but that doesn't mean it should be broken like this...

Comment 1

[Fred Wenzel [:wenzel]]

This is still around in the new version, still easy to fix, and thus a 5.0.7 bug :)

Comment 2

[Fred Wenzel [:wenzel]]

I love how boldly I claimed this, and for some reason it still didn't make it into 5.0.7 after all ;)

I'm on it.

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

I removed the page and am now performing a permanent (not: 302) redirect to the respective add-ons details page.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 393586 [details] [diff] [review]
Patch, rev. 1

(In reply to comment #2)
> I love how boldly I claimed this, and for some reason it still didn't make it
> into 5.0.7 after all ;)

Fortune favors the bold!

Comment 5

[Fred Wenzel [:wenzel]]

Good things come to those who wait. :) r48918

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://preview.addons.mozilla.org/addons/previews/1729 301s to https://preview.addons.mozilla.org/en-US/firefox/addon/1729

Comment 7

[Philip Chee]

Uh, Thanks, I think.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Uh, Thanks, I think.

?

Comment 9

[Philip Chee]

>> Uh, Thanks, I think.
> ?
I was expecting "FIXED" to mean a proper working previews page. Not a redirect.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #9)
> >> Uh, Thanks, I think.
> > ?
> I was expecting "FIXED" to mean a proper working previews page. Not a redirect.

Did you read the bug?  The verification matches the fix.

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to comment #9)
> >> Uh, Thanks, I think.
> > ?
> I was expecting "FIXED" to mean a proper working previews page. Not a redirect.

How would that differ from the functionality that exists?