429349 - memory leaking in nsTSMManager::UpdateComposing()

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

In nsTSMManager::UpdateComposing(), nsTSMManager caches the given composition string with |retain|. However that is only realeased at composition end, so, 2nd time or later UpdateComposing(), that may be leaking.

Comment 1

[Josh Aas]

Comment on attachment 316044 [details] [diff] [review]
Patch v1.0

  sComposingString = aComposingString;
  [sComposingString retain];

Just do:

  sComposingString = [aComposingString retain];

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1

thank you, josh.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 316050 [details] [diff] [review]
Patch v1.1

simple memory leaking bug. it occurs many time. and low risk.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 316050 [details] [diff] [review]
Patch v1.1

a1.9=beltzner

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.