429405 - Compile error in nsMsgHeaderParser.cpp

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Christian Schmidt]

After the check-in for bug 413874 "tidy up string usage in mailnews" (I am not authorized to view that bug, so I don't know what it is about) I can no longer compile mailnews/mime/src/nsMsgHeaderParser.cpp.

c++ -o nsMsgHeaderParser.o -c  -DENABLE_SMIME -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6.23.15-137\" -DOSARCH=Linux  -I. -I. -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/msgbase -I../../../dist/include/msgbaseutil -I../../../dist/include/pref -I../../../dist/include/js -I../../../dist/include/necko -I../../../dist/include/uconv -I../../../dist/include/unicharutil -I../../../dist/include/msgcompose -I../../../dist/include/dom -I../../../dist/include/intl -I../../../dist/include/msgimap -I../../../dist/include/exthandler -I../../../dist/include/mailnews -I../../../dist/include/chardet -I../../../dist/include/caps -I../../../dist/include/mimetype -I../../../dist/include/xpconnect -I../../../dist/include/nkcache -I../../../dist/include/pipnss -I../../../dist/include/imglib2 -I../../../dist/include/content -I../../../dist/include/htmlparser -I../../../dist/include/layout -I../../../dist/include/msgsmime -I../../../dist/include   -I../../../dist/include/mime -I../../../dist/include/nspr     -I/usr/X11R6/include   -fPIC  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_chsc -DTRACING -g -fno-inline -Os -freorder-blocks -fno-reorder-functions -finline-limit=50  -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsMsgHeaderParser.pp nsMsgHeaderParser.cpp
nsMsgHeaderParser.cpp: In function ‘char* msg_remove_duplicate_addresses(const char*, const char*, PRBool)’:
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1475: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1473: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1468: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1463: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1461: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1436: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1432: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
nsMsgHeaderParser.cpp:1562: error: jump to label ‘FAIL’
nsMsgHeaderParser.cpp:1428: error:   from here
nsMsgHeaderParser.cpp:1536: error:   crosses initialization of ‘PRUint32 outlen’
gmake[1]: *** [nsMsgHeaderParser.o] Error 1


I am building using gcc version 4.1.2 20070925 (Red Hat 4.1.2-33) on Fedora 8.

Comment 1

[Christian Schmidt]

A fix has just been committed by Mats Palmgren.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mailnews/mime/src&command=DIFF_FRAMESET&file=nsMsgHeaderParser.cpp&rev1=1.65&rev2=1.66&root=/cvsroot