429410 - Admin users not receiving email notifications

Status: RESOLVED INCOMPLETE

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Alix Franquet [:alix]]

Admin users (ex: drolnitzky, Propaganda group) do not get email notification of activity in their group - even with "always send email notifications" selected in their account.

Comment 1

[Alex Buchanan [:abuchanan]]

I thought we had solved the email problems.  Can you double check if this is wokring?

Comment 2

[Alex Buchanan [:abuchanan]]

bump

Comment 3

[Paul Booker]

@Alex

Please feel free to reassign.

Comment 4

[Alex Buchanan [:abuchanan]]

Paul, could you try fixing this one?  I'm pretty busy so far, and it's really important we get it working this month.

Thanks.

Comment 5

[Paul Booker]

Sure, ill take a look ..

Comment 6

[Paul Booker]

@Alex

It looks as though all mail is being rerouted to [e-mail] and that this cannot be configured otherwise ?  
https://spreadfirefox.authstage.mozilla.com/admin/settings/reroute_email

I created a new test account successfully but did not receive any email. I suspect this was delivered to [e-mail].  Is it possible to reroute mail to [e-mail] or if this is a group add [e-mail] to the group or disable this module? Would you please advise.

Thanks Paul

Comment 7

[Alex Buchanan [:abuchanan]]

(In reply to comment #6)
> @Alex
> 
> It looks as though all mail is being rerouted to [e-mail] and that
> this cannot be configured otherwise ?  
> https://spreadfirefox.authstage.mozilla.com/admin/settings/reroute_email
> 
> I created a new test account successfully but did not receive any email. I
> suspect this was delivered to [e-mail].  Is it possible to reroute
> mail to [e-mail] or if this is a group add
> [e-mail] to the group or disable this module? Would you please
> advise.
> 
> Thanks Paul

Yes, all stage email gets rerouted to a shared list.  To be added see,
https://wiki.mozilla.org/Spreadfirefox#Spreadfirefox.stage

Comment 8

[raymond [:retornam] (inactive)]

This is now happening to all users. New users who create accounts also do no receive emails

Comment 9

[Paul Booker]

Unassiging myself from this bug to allow others to pick it up.

Comment 10

[Sam Keen]

I created two different 'test' accounts on production and both accounts received the "welcome" email so that seems to work.

As for reference above to: 

"always send email notifications" selected
in their account.

I don't see anywhere in the current admin UI to configure email notifications for organic groups (Projects).  
What may have happened is that the option was there but has been turned off, or that responsibility has been moved to another module (notification,Messaging) as alluded to here: http://drupal.org/node/720086

I research some more to see if we can get these features back

Comment 11

[Sam Keen]

So in Site_building->Modules->Organic_groups there is:
"Organic Groups Notifications" (which is currently disabled)

It depends on 
Notifications (disabled), Content Notifications (disabled), Notifications Lite (disabled), Messaging (disabled), Token (enabled)

I'll start turning these on in my local running install of SFX and see if I can get it working.

Let me know if anyone recalls a reason to turning Organic Groups Notifications off :)

Comment 12

[Mary]

Buchanan - I think you might know why...do tell!

Comment 13

[Alex Buchanan [:abuchanan]]

Not absolutely sure, but I remember there were a couple issues...

1) a transition from Notifications module to Messaging (or vice versa?)

2) at one point there was a DB table with about 1 million queued messages.  that needs to be cleared before we re-enable this, so that we don't end up processing and sending 1 million messages in one day.  we can load up a production DB and see if that still exists, and ask IT to clear it.

Comment 14

[Sam Keen]

Thanks for the Input Alex,

I looked into what you noted here:
There is a queue table named `notifications_queue` that yes, should be truncated on prod as step one of enabling this.

Comment 15

[Sam Keen]

I got these notifications working on a local build of sfx, in short, what I did.

Upgraded and enabled the notify and messaging module parts needed by OG Notify, then enabled OG notify.

Before moving forward on implementing this, we should discuss what the expected email traffic will be and what the default settings will be for the notify queue (don't want to get back to a million message queue :)


Little more detail of what I did:

1) Enable Notifications and Messaging

The modules Notification and Messaging were in the code base but turned off, before enabling them, I updated them to the newest versions

Notification Module is at 5.x-1.2, taking opportunity to upgrade to 5.x-1.3 before turning on
http://drupal.org/node/451546

Messaging Module is at 5.x-1.1 taking opportunity to upgrade to 5.x-1.3 before turning on
http://drupal.org/node/451542

enabled

    * Notifications
    * Content Notifications
    * Notifications Lite
    * Messaging
    * Messaging :: Simple Mail

then

    * Organic Groups Notifications


2.) Enable Mail Messaging
/admin/messaging/settings and set "Default send method:" mail


========
Now for any user on their /user/{USER-ID}/edit page there is "Messaging settings" section with one checkbox

[ ] Automatically enable notifications for any projects that I join.
Project notifications can also be customised in greater detail if required.

"customised" is a link (/user/{USER-ID}/notifications/group as an example) (and yes it is misspelled) but if a regular user follows it they get:
"Access denied You are not authorized to access this page."

=====
An Admin can go to /admin/messaging which has:
Messaging methods
    Configuration of sending methods
Messaging templates
    Configuration of message templates
Notifications settings
    Site settings for user notifications.
Notifications status
    Manage notifications status queue


and /admin/og/og :: "Messaging & Notifications" section, which in addition to templates has:

[] Autosubscribe users to any groups that they join.
Automatically enable notifications by default. Users can override this via their account page. Changing this setting will only affect new users and those who have not overridden the system default.



======
With a test account I created a Project and got an email that stated I was the admin of Project "X" (after flushing the queue,  I think cron.php would normally do this)

Then with another account I added content to the Project, and the admin account got email that there was new content in Project "X".

Comment 16

[Paul Booker]

Attachment: screenshot

To fix this problem ..

"customised" is a link (/user/{USER-ID}/notifications/group as an example) (and
yes it is misspelled) but if a regular user follows it they get:
"Access denied You are not authorized to access this page."

.. you will need to give the permission "subscribe to content in groups" to an authenticated user

Best, 
Paul Booker
Appcoast

Comment 17

[Paul Booker]

Attachment: screenshot

To see the links @ /admin/messaging you will need to assign the permission "administer messagaing" to the vanguard role if your not using the account UID=1

Comment 18

[Paul Booker]

Attachment: screenshot

Other permission settings for the notification module.

The permission "administer notifications" needs to be enabled in order to get the "Notification status" link on @ admin/settings

Comment 19

[Sam Keen]

thx for the help Paul,

- give the permission "subscribe to content in groups" to an
authenticated user fixed the customized link issue on 

I'll add your other comments to the 'deploy' actions we can run through in stage and then prod.

Comment 20

[Paul Booker]

Hi Sam,

Sounds Good.

Best, 
Paul Booker
Appcoast

Comment 21

[Sam Keen]

Stage is updated, and the parts of notification and messaging needed for OG Notification have been turned on.  Here is what I have done so far (documenting it here so we can easily re-apply it to prod once we've tested on stage)

    * update notifications and messaging modules (the updated versions are checked into svn)

    * go to /admin/build/modules

      Messaging should be at: 5.x-1.3
      Notifications should be at: 5.x-1.3

    * enabled
          o Notifications
                + Content Notifications
                + Notifications Lite
          o Messaging
                + Simple Mail
          o Organic Groups Notifications

At this point the modules are "enabled", below is the configuration of what to expose to certain roles and should certainly be vetted by someone who's solid with the roles strategy on sfx. If you change anything in the list below, please re-post the entire (edited list) so we can easily re-apply it to production.

    * got to /admin/user/access
          o messaging module :: check: "administer messaging" to the vanguard role
          o administer notifications :: check: "administer notifications" to the vanguard role
          o notifications_content module :: check: "subscribe to content in groups" to the authenticated user


the messaging module has a (drupal) cron hook that flushes the mail queue, but I am not sure how or if were are enacting the hook on stage (cron.php is blocked in htaccess).  Regardless, an admin can see and manage the queue at /admin/messaging/notifications-status


so at this point if someone (with more sfx policy experience than I) can work with me on testing stage and getting it's access rights dialed in, just let me know.

Comment 22

[Sam Keen]

562140 was resolved so I completed the steps in comment 21 above.

Can I get a sfx drupal admin to login and review/adjust the current settings on production.

thx.

Comment 23

[Paul Booker]

@Mary,

Can i get clearance to give Sam full administrative access to spreadfirefox.com (production) ?

Now is also probably a good time for us review access privileges for spreadfirefox.com production / stage to ensure that nobody has more privileges than they need to carry out their tasks 

Best, 
Paul Booker

Comment 24

[Alex Buchanan [:abuchanan]]

(In reply to comment #22)
> 562140 was resolved so I completed the steps in comment 21 above.
> 
> Can I get a sfx drupal admin to login and review/adjust the current settings on
> production.
> 
> thx.

Your account already has admin access

Comment 25

[Sam Keen]

I have full rights,

The intent of my comment was to spur the sort of collaboration you suggested above. Review that the proper checkboxes on the proper admin forms are in place for this particular drupal install to ensure that the users of the site have the amount of access deemed proper by mozilla (info i don't have at this point, I'm just the coder :)

Comment 26

[Mary]

@Paul:  yes, will double check -- good point!
@Sam:  Are you all set?

I can add Sam just need his SFx id!

Comment 27

[Paul Booker]

@Sam

Production looks good with the exception that the following permission needs to be brought over  ..

  o notifications_content module :: check: "subscribe to content in
groups" to the authenticated user


I also confirmed that our messaging queue has been purged @ admin/messaging/notifications-status 

Best,
Paul Booker
Appcoast

Comment 28

[Sam Keen]

I just went in and made this change,

on /admin/user/access

notifications_content module 
i checked 'subscribe to content' for 'authenticated user'

(note that under og_notifications module, 'subscribe to content in groups' was already checked for 'authenticated user')

Comment 29

[Sam Keen]

as a test i went to "My Account" -> "Notification" and clicked projects in the list (ending up here http://www.spreadfirefox.com/user/306409/notifications/group)

For the project I started , i checked "All posts in this project" and selected "Immediately"

I then logged in as my 'test' user and joined the project and submitted a post.

That did create a notification and it is in the queue : http://www.spreadfirefox.com/admin/messaging/notifications-status

What should happen in the drupal cron hook gets fired (i'm told every 15min) and that will cause the notification queue to be processed and the mail to be sent.

And that DID happen, I received the email at my accounts email address.

so, unless we need any more access configuration changes i dare say this may be fixed??

Comment 30

[Paul Booker]

I was also able to reproduce the above.

Best, 
Paul Booker
Appcoast

Comment 31

[raymond [:retornam] (inactive)]

(In reply to comment #30)
> I was also able to reproduce the above.
> 
> Best, 
> Paul Booker
> Appcoast

based comment #29 and #30 marking this as verified fixed on hhttp://www.spreadfirefox.com/admin/messaging/notifications-status

Comment 32

[Mary]

Hey all: Reopening this again. Getting complaints from folks about SFx "spamming" them + random replies to SFx-admin.

I can't tell if these users are in fact group admins + have been caught offguard by notifications. I can't search users by email address.

So, is it possible that all folks in a group are being notified?

Please let me know.  Thinking we need to turn this off.  Thanks!

Comment 33

[Sam Keen]

I think all (most) are being notified, I looked at the Organic Groups admin panel and under "Messages and Notifications" , "Autosubscribe users to any groups that they join" was checked.
I'm pretty sure this is the setting that affects the messages in question, but this Drupal :) , so I could be mistaken.

I went ahead and Unchecked this, but nothing would change for existing users, they would still be subscribed.  They can, (as they always have been able), go to their notification settings and turn them off (i.e. http://www.spreadfirefox.com/user/{USER-ID}/notifications/group)  but that's buried pretty deep and doesn't have the best work flow

Let me know if you want all Group (Project) messaging shut down :(

Comment 34

[Mary]

Hey there:  This is def. pissing peeps off.  Here's an idea - please let me know what you guys think.

* Disable notification
* Add "Subscribe Notifications from this Project" to the right sidebar that is on each project page. See example:  http://www.spreadfirefox.com/node/382
* Reset notifications so that only people that opt-in receive them.

Let me know how much time/work this would be or if you have any other ideas.

Comment 35

[Paul Booker]

Mary / Sam

I'll pick this up first thing in the morning.

Best, Paul

Comment 36

[Mary]

Thanks :)

Comment 37

[Paul Booker]

@Mary

Great idea.

I think it should not take more than  a couple of days work to write a script that will turn off group notifications for all users and add  the "Subscribe to Notifications" link to the groups details block. 

Not sure how big the problem is here but  could we just make a post on spreadfirefox.com  informing users how to turn off notifications on a group by group basis?


To minimize delays i'll just mention here that i still need to get a recent copy of the production database for my local server.

Best, 
Paul Booker
Appcoast

Comment 38

[Mary]

Hey there:  I don't think a post would be helpful.  Considering sign-ins to the site I'm not sure how many people will see it.  Sam:  Can we turn this off now while Paul works on a solution?

Alex:  Can you please get Paul a local copy of SFx, pretty please? 

Thanks!

Comment 39

[Alex Buchanan [:abuchanan]]

db dump: http://people.mozilla.com/~abuchanan/sfx-dump.sql.gz

Comment 40

[Wil Clouser [:clouserw]]

That dump is full of all kinds of sensitive info and this is a public bug.  I'm marking this confidential, please remove the dump from that URL.

Comment 41

[Alex Buchanan [:abuchanan]]

I ran a script to clean out sensitive stuff.

But, since you're worried, I removed from that URL.

Comment 42

[Wil Clouser [:clouserw]]

(In reply to comment #41)
> I ran a script to clean out sensitive stuff.
> 
> But, since you're worried, I removed from that URL.

Thanks, I saw that but I don't think it was good enough.  There are still a bunch of tables that could be used to gain info like finding who the admin users are from users_roles, etc.

Comment 43

[Alex Buchanan [:abuchanan]]

Ya, Wil makes good points, I don't like passing out DBs based on the production DB.  We'll have to figure something else out for community members.

Paul, can you get by without a production dump?

Comment 44

[Paul Booker]

@Alex

I could try an earlier dump that's up on stage

@Wil

Just to let you know i have full administrative access on spreadfirefox.com

@Sam

I am off this Friday so it's looking as though i'll not be able to resolve this bug before the weekend . Will you be ok to work on this bug? I'll research the problem today and see how i can help things along ..

Best, 
Paul Booker
Appcoast

Comment 45

[Wil Clouser [:clouserw]]

> @Wil
> Just to let you know i have full administrative access on spreadfirefox.com

I don't know anything about your privileges.  My concern was a dump being linked to in a public bug.

Comment 46

[Paul Booker]

@Wil

Is it ok  for Alex to make the download available provided that is not linked to a public bug ?

Best, 
Paul Booker
Appcoast

Comment 47

[Wil Clouser [:clouserw]]

I don't know the details of your relationship here.  If you're under contract, it's fine with me.  If you're not, you should talk to whoever is your main contact at mozilla about getting access to confidential information.

Comment 48

[Paul Booker]

spreadfirefox.com is down  ..

Service Unavailable

The service is temporarily unavailable. Please try again later.