429505 - OnItemRemoved() fails to live-update for children that are folder-shortcuts

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

When a folder shortcut is removed, the query item id is send in the notification. Therefore, NHR should check for that in the observer method.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix + test

Comment 2

[Dietrich Ayala (:dietrich)]

drivers: easy to reproduce live-update bug. low risk fix, has test.

Comment 3

[Dietrich Ayala (:dietrich)]

drivers: also, this blocks another blocker

STR:

1. create a new bookmark w/ URI "place:folder=TOOLBAR" in the bookmarks menu
2. open the library, click the menu folder in the left pane
3. expand the menu folder in the left pane, so that the new toolbar folder shortcut is visible
4. delete the folder shortcut in the *right* pane

Expected: toolbar shortcut in the left pane disappears

Actual: toolbar shortcut still visible in the left pane, even though it's been deleted

Comment 4

[Asaf Romano (gone)]

Shouldn't you check against both ids?

Comment 5

[Asaf Romano (gone)]

Comment on attachment 316245 [details] [diff] [review]
fix + test

<dietrich>	"Shouldn't you check against both ids?" - isn't that what that patch does?

right sorry,
r=mano (check the test license header, is that really marco's?)

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 316245 [details] [diff] [review]
fix + test

Drivers: see comment #2

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 316245 [details] [diff] [review]
fix + test

a1.9+=damons

Comment 8

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistoryResult.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp,v  <--  nsNavHistoryResult.cpp
new revision: 1.142; previous revision: 1.141
done
Checking in toolkit/components/places/tests/bookmarks/test_424958-json-quoted-folders.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_424958-json-quoted-folders.js,v  <--  test_424958-json-quoted-folders.js
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/toolkit/components/places/tests/unit/test_429505_remove_shortcuts.js,v
done
Checking in toolkit/components/places/tests/unit/test_429505_remove_shortcuts.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_429505_remove_shortcuts.js,v  <--  test_429505_remove_shortcuts.js
initial revision: 1.1
done

Comment 9

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090128 Shiretoko/3.1b3pre

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv