429531 - Location bar should show non-word-boundary matches below word-boundary matches

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ed Lee :Mardak]

We prune results that don't match on word boundaries, so if we end up not matching anything, we show nothing. But it could be useful to show at least something if we don't have enough word-boundary results.

Comment 1

[Ed Lee :Mardak]

blocking-firefox3? as this is what beltzner wanted to grant blocking for bug 429498.

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Simple patch, simple idea.

New pref to control whether or not we match on word boundaries always, or first try word boundary then try matching anywhere.

If we search through everything and want more results, continue searching but relax the condition of matching on word boundaries.

Works with the "use previous results" optimization as well.

Comment 3

[Ed Lee :Mardak]

(The pref value of 2 to always match on word boundaries is mostly just for testing to make sure the word boundary logic still works. ;))

Comment 4

[Ed Lee :Mardak]

Attachment: screenshot of v1

Screenshot of matching on word boundaries first and then trying to match anywhere.

https://build.mozilla.org/tryserver-builds/2008-04-17_17:[e-mail]/

Comment 5

[Ed Lee :Mardak]

Attachment: v1.1

Same as v1 but updated some comments.

Comment 6

[Ed Lee :Mardak]

This at most doubles the search time, bug because we have bug 422177 where we restart where the previous search left off, this isn't bad at all. We make sure we display any word boundary matches from history before trying to find non-word boundary matches.

This lets us match "toronto" for "thisplacetoronto.com".

Comment 7

[Mike Connor [:mconnor]]

This is important, marking as blocking.

Comment 8

[[:Aleksej]]

With this bug fixed, it will be nice to have Cyrillic letters added to the list of non-word-boundaries as mentioned in bug 393678#c33. Thanks.

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 316351 [details] [diff] [review]
v1.1

r=me, thanks!

Comment 10

[Ed Lee :Mardak]

Comment on attachment 316351 [details] [diff] [review]
v1.1

Changes some prefs to allow showing non-word boundary matches below word boundary matches.. with testcase too!

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 316351 [details] [diff] [review]
v1.1

a1.9=beltzner

Comment 12

[Ed Lee :Mardak]

http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/rev/355b8f5bdc37
http://hg.mozilla.org/mozilla-central/index.cgi/rev/355b8f5bdc37

Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.325; previous revision: 1.324
done
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.297; previous revision: 1.296
done
Checking in toolkit/components/places/src/nsNavHistory.h;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.h,v  <--  nsNavHistory.h
new revision: 1.157; previous revision: 1.156
done
Checking in toolkit/components/places/src/nsNavHistoryAutoComplete.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryAutoComplete.cpp,v  <--  nsNavHistoryAutoComplete.cpp
new revision: 1.58; previous revision: 1.57
done
Checking in toolkit/components/places/tests/autocomplete/test_word_boundary_search.js;
/cvsroot/mozilla/toolkit/components/places/tests/autocomplete/test_word_boundary_search.js,v  <--  test_word_boundary_search.js
new revision: 1.5; previous revision: 1.4
done