429572 - Don't hardcode Security Update color on Update History

Status: NEW

(Firefox :: Theme, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (X11; U; OpenBSD i386; en-US; rv:1.8.1.6) Gecko/20070819 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041606 Minefield/3.0pre

This can be difficult to read for people with visibility disability.

See screenshot, with High Contrast theme.

Reproducible: Always

Comment 1

[Andrés Delfino]

Attachment: Security Update message in red, with High Contrast theme.

Comment 2

[Kai Liu]

But what non-hardcoded color could we use?  Highlight color's blue.  And then there's...?  Hopefully, nobody is crazy enough that their system is set to use that shade of red as the base color.  Be nice to fix if we could, but it's not really feasible ATM.

Comment 3

[Andrés Delfino]

(In reply to comment #2)
> But what non-hardcoded color could we use?  Highlight color's blue.  And then
> there's...?  Hopefully, nobody is crazy enough that their system is set to use
> that shade of red as the base color.  Be nice to fix if we could, but it's not
> really feasible ATM.
> 

I don't see why using normal text color, or GrayText, breaks something.

Comment 4

[Kai Liu]

So that we can give security updates a special color that stands out, of course...

Hmm.  Wait.  Is there ever an update that *doesn't* get marked as a security update?  I think I see your point...

Comment 5

[Andrés Delfino]

(In reply to comment #4)
> So that we can give security updates a special color that stands out, of
> course...
> 
> Hmm.  Wait.  Is there ever an update that *doesn't* get marked as a security
> update?  I think I see your point...
> 

I guess so. But, if you want to differentiate between updates, we should use icons instead of hard-coded colors.