one accesskey for different context menu items ("View Selection Source" and "View MathML Source")

RESOLVED FIXED in Firefox 3.1a2

Status

()

Firefox
Menus
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: wladow, Assigned: wladow)

Tracking

Trunk
Firefox 3.1a2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

Menu-items with id context-viewpartialsource-selection and context-viewpartialsource-mathml use one accesskey defined as viewPartialSourceCmd.accesskey

This should be fixed once the tree is reopened for string changes.

Comment 1

10 years ago
As you can see at <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/nsContextMenu.js&rev=1.59&mark=172-175#170>, the corresponding menu items are never shown at the same time - so using a single accesskey is fine in this case. ->INVALID
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INVALID
(Assignee)

Comment 2

10 years ago
There should be at least a localization note, that it is used for BOTH items, because when localizer chooses accesskey he has no idea about that and can choose letter which isn't present in both strings (as I did f.e.). Make localization world easier not harder. REOP
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(Assignee)

Comment 3

10 years ago
Created attachment 331122 [details] [diff] [review]
add localization note
Assignee: nobody → wladow
Status: REOPENED → ASSIGNED
Attachment #331122 - Flags: review?(gavin.sharp)
Comment on attachment 331122 [details] [diff] [review]
add localization note

>diff -r b0d13430bc76 browser/locales/en-US/chrome/browser/browser.dtd

> <!ENTITY viewPartialSourceForSelectionCmd.label "View Selection Source">
> <!ENTITY viewPartialSourceForMathMLCmd.label    "View MathML Source">
>+<!-- LOCALIZATION NOTE: viewPartialSourceCmd.accesskey is used for both 
>+         viewPartialSourceForSelectionCmd.label and viewPartialSourceForMathMLCmd.label -->
> <!ENTITY viewPartialSourceCmd.accesskey "e">

Wouldn't hurt to use the format from http://developer.mozilla.org/en/docs/Localization_notes (just add parentheses and move the ":")
Attachment #331122 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed

Comment 6

10 years ago
http://hg.mozilla.org/index.cgi/mozilla-central/rev/7db410f854a2
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2

Updated

10 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.