429639 - Crash [@ nsXULListboxAccessible::~nsXULListboxAccessible() ]

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Three crashes that happened with beta 5. One of the reports indicates the address bar/Location bar.
http://crash-stats.mozilla.com/report/list?range_unit=weeks&query_search=signature&query_type=contains&product=Firefox&platform=windows%2Cmac%2Clinux&version=Firefox%3A3.0b5%2CFirefox%3A3.0pre&branch=1.9&signature=nsXULListboxAccessible%3A%3A~nsXULListboxAccessible()&query=Access&range_value=1

Comment 1

[Damon Sicore (:damons)]

Hard to block with only three crashes.  Please re-nom if you disagree.

Comment 2

[alexander :surkov (:asurkov)]

They pointed to http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/accessible/src/xul/nsXULSelectAccessible.h&rev=1.35&mark=111#111. Why do we keep empty virtual destructors at all?

Comment 3

[Marco Zehe (:MarcoZ)]

Alexander, anything else we want to do on this one? It still appeared a couple of times in b5 over the past week.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Mass un-assigning bugs assigned to Aaron.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Is this bug stale?

Alexander, not sure of your question but virtual destructors are generally recommended (in case subclasses or subsubclasses ... have special cleanup to do)

Comment 6

[alexander :surkov (:asurkov)]

I mean no one of our destructors makes anything, all of them are empty iirc. So I can't see a reason to keep them.