Closed Bug 429664 Opened 16 years ago Closed 16 years ago

Floating events overlapps events with timezone

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: berend.cornelius09)

Details

Attachments

(1 file)

Attached image screen shot
STEPS TO REPRODUCE:
===================

- set lightning timezone to Europe/Paris
- create an event start time 12:00, end time 13:00
- create an second event start time 13:00 end time 18:00 and change the timezone to 'local time' (floating)
- change the timezone of lightning to Europe/Moscow
- restart thunderbird/lightning 

RESULT:
=======

- the events overlapps (see attachment)

EXPECTED RESULT:
================

- the events should not overlapps

REPRODUCIBLE:
=============

- always
Flags: wanted-calendar0.9?
Flags: wanted-calendar0.9? → wanted-calendar0.9+
Flags: blocking-calendar0.9?
Flags: blocking-calendar0.9? → blocking-calendar0.9+
Assignee: nobody → Berend.Cornelius
Whiteboard: [needs patch]
After some inspection, I think the problem lies here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/content/calendar-multiday-view.xml&rev=1.195#882
There, the events are sorted by startdate. But they are still in their original timezone. And with floating events, sorting is a bit weird:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/base/src/calDateTime.cpp&rev=1.80#585
My guess is that the solution is to convert the items into the display timezone before the sorting, and thus before trying to figure out their width.

(Others may suggest that the sorting is wrong, but I'm not sure there is a better way. And changing it might break other places. Also see bug 396668)

Oh, and to reproduce this, I had to add a third event in some another timezone, but I kept the sunbird timezone to what it was. So I had one event in my timezone, one floating and one in Los Angeles timezone.
As I and also Andreas tested this is fixed with Bug 437412.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [needs patch]
Target Milestone: --- → 0.9
Flags: wanted-calendar0.9+
Checked in lightning 2008082620 and Sunbird 20080826 -> VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.