429690 - browser tests cannot be run individually

Status: VERIFIED FIXED

(Testing :: Mochitest, defect)

Description

[Shawn Wilsher :sdwilsh]

It'd be really useful to be able to run only one test, instead of all the tests in a directory.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This makes --test-path handle a single file. A few other minor changes:

- change summary foreground colour to white (easier to read on green or red, I find)
- make results div flex (makes it look better in the "no tests" case). This makes text inside it wrap rather than scroll, so add a default window width to avoid that happening in the common case.
- have getHTMLLogFromTests and Tester.start support running no tests, and use this when passed an invalid --test-path (with appropriate error message rather than failing silently)

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 352881 [details] [diff] [review]
patch

>+
>+        // Invalid testPath...
>+        if (!testsDir.exists())
>+          return [];
>+
>+        // If we were passed a specific file, run only that test.
>+        if (testsDir.isFile() && fileNameRegexp.test(testsDir.leafName))
>+          return [new browserTestFile(requestPath + "/" + gConfig.testPath)];

Make this return an empty array if it is a file but doesn't match the regexp

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Went through full&partial browser chrome test runs on Mac and Windows with that patch, it's ready to land.

Comment 5

[Shawn Wilsher :sdwilsh]

Does this then work with TEST_FILE when doing top level make mochitest-browser?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Does setting TEST_FILE cause python.py to be invoked with --test-path? If so, probably!

Comment 7

[Shawn Wilsher :sdwilsh]

It sure does!

Comment 8

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/fe5e6c0bb20c

I think I'll probably land this on 1.9.1 and 1.9.0 as well (need to check the status of the harness on 1.9.0, not sure we've been backporting all the fixes).

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed, per bug 472677 comment 6.

https://developer.mozilla.org/en/Browser_chrome_tests#section_5
will need to be updated (after branch(es) checkin).

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> https://developer.mozilla.org/en/Browser_chrome_tests#section_5
> will need to be updated (after branch(es) checkin).

I've updated that document (it was also filled with falsehoods and inaccuracies).

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-1.9.1/rev/bb309a8e6f0f