Closed
Bug 429719
Opened 17 years ago
Closed 17 years ago
buildbot 0.7.7 lies about being able to force a build
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
|
2.54 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Some of the new WebStatus pages claim to be able to force and/or stop builds when they cannot. This patch fixes that. Filed upstream at http://buildbot.net/trac/ticket/246
I did a quick manual test on my lappy and it seems fine. I'm running unit tests right now.
Attachment #316484 -
Flags: review?(rcampbell)
|
Assignee | |
Comment 1•17 years ago
|
||
PASSED (skips=27, successes=281)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 316484 [details] [diff] [review]
[checked in] make buildbot stop lying.
you could simplify your condition to just "if control:" but this should do. Thanks!
Attachment #316484 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 316484 [details] [diff] [review]
[checked in] make buildbot stop lying.
Checking in buildbot/status/web/baseweb.py;
/cvsroot/mozilla/tools/buildbot/buildbot/status/web/baseweb.py,v <-- baseweb.py
new revision: 1.2; previous revision: 1.1
done
Attachment #316484 -
Attachment description: make buildbot stop lying. → [checked in] make buildbot stop lying.
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•