429804 - Add Foreign Keys to Multiselect fields

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Alex Eiser]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/526.1+ (KHTML, like Gecko) Version/3.1.1 Safari/525.18
Build Identifier: HEAD

Add FK support to CASCADE deletes of a bug to the multiselect tables

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Alex Eiser]

Attachment: patch for adding FK to multiselects

Comment 2

[Max Kanat-Alexander]

Comment on attachment 316561 [details] [diff] [review]
patch for adding FK to multiselects

This had a few problems, which I fixed myself:

* The checksetup code didn't actually work.

* There was no need to use selectall_arrayref, you could have used selectcol_arrayref. Also, DISTINCT was unnecessary there (in checksetup).

* We shouldn't specify the definition twice, so I removed it from Bugzilla::DB::Schema.

* 'RESTRICT' is the default for DELETE so you don't need to specify it.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Here's the version I'm going to check in.

Comment 4

[Max Kanat-Alexander]

Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.114; previous revision: 1.113
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.103; previous revision: 1.102
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.52; previous revision: 1.51
done