bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Add Foreign Keys to Multiselect fields

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Database
--
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Alex Eiser, Assigned: Alex Eiser)

Tracking

(Blocks: 1 bug)

3.1.3
Bugzilla 3.4
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
3.32 KB, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/526.1+ (KHTML, like Gecko) Version/3.1.1 Safari/525.18
Build Identifier: HEAD

Add FK support to CASCADE deletes of a bug to the multiselect tables

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Updated

10 years ago
Blocks: 109473
(Assignee)

Comment 1

10 years ago
Created attachment 316561 [details] [diff] [review]
patch for adding FK to multiselects
Attachment #316561 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #316561 - Flags: review? → review?(mkanat)

Updated

10 years ago
Assignee: database → aeiser
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Mac OS X → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 4.0
Version: unspecified → 3.1.3

Comment 2

10 years ago
Comment on attachment 316561 [details] [diff] [review]
patch for adding FK to multiselects

This had a few problems, which I fixed myself:

* The checksetup code didn't actually work.

* There was no need to use selectall_arrayref, you could have used selectcol_arrayref. Also, DISTINCT was unnecessary there (in checksetup).

* We shouldn't specify the definition twice, so I removed it from Bugzilla::DB::Schema.

* 'RESTRICT' is the default for DELETE so you don't need to specify it.
Attachment #316561 - Flags: review?(mkanat) → review-

Comment 3

10 years ago
Created attachment 327281 [details] [diff] [review]
v2

Here's the version I'm going to check in.
Attachment #316561 - Attachment is obsolete: true
Attachment #327281 - Flags: review+

Comment 4

10 years ago
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.114; previous revision: 1.113
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.103; previous revision: 1.102
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.52; previous revision: 1.51
done
Severity: normal → enhancement
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Flags: approval+
Resolution: --- → FIXED

Updated

10 years ago
Summary: Add Foreign Keys to Multiselect fieds → Add Foreign Keys to Multiselect fields

Updated

10 years ago
Target Milestone: Bugzilla 4.0 → Bugzilla 3.4
You need to log in before you can comment on or make changes to this bug.