nsXULTemplateBuilder.cpp references invalid RDF elemant

VERIFIED FIXED in M17

Status

()

Core
RDF
P3
trivial
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: dmose, Assigned: Chris Waterson)

Tracking

(Blocks: 1 bug, {arch})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Specifically, kRDF_child: 

6513 #define TREE_PROPERTY_HACK 1
6514 #if defined(TREE_PROPERTY_HACK)
6515     if (! len) {
6516         // Some ever-present membership tests.
6517         mContainmentProperties.Add(kNC_child);
6518         mContainmentProperties.Add(kNC_Folder);
6519         mContainmentProperties.Add(kRDF_child);
6520     }
6521 #endif
6522 

The core RDF namespace doesn't have an property called child.  I couldn't find
any other obvious references to it in the tree just by using lxr.
(Reporter)

Updated

18 years ago
Blocks: 11650
Keywords: arch
(Assignee)

Comment 1

18 years ago
dmose: could you try chopping it out to see if "anything breaks"? I think only 
rjc or I would've done something that relied on rdf:child, and my guess is that 
most of the stuff is done using nc:child now, anyway.
Status: NEW → ASSIGNED

Comment 2

18 years ago
Yeah, I think RDF#Child is merely historical and hopefully not actually used 
anywhere.
(Assignee)

Comment 3

18 years ago
Allright. I'll remove it, and we can just hand tweak any datasources that still
rely on it working.
Target Milestone: --- → M17
(Assignee)

Comment 4

18 years ago
Created attachment 10376 [details] [diff] [review]
rip out kRDF_child
(Assignee)

Comment 5

18 years ago
rjc, r=?

Comment 6

18 years ago
r=rjc  with pleasure
(Assignee)

Comment 7

18 years ago
fix checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

17 years ago
QA Contact: tever → bbaetz
VERIFIED that the patch was checked in...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.