430078 - jsDriver.pl Perl Getopt::Long does not support repeat qualifiers on options

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

bug 418304 replaced the use of Getopt::Mixed with Getopt::Long however when I performed the review I failed to test on Mac OS X which does not appear to support the repeat qualifiers on options.

Error in option spec: "engine|e=s{1,}"
Error in option spec: "list|l=s{1,}"
Error in option spec: "neglist|L=s{1,}"

Igor, sorry for missing this. I'll test removing the repeat qualifiers and submit a patch shortly.

Comment 1

[Igor Bukanov]

(In reply to comment #0)
> Error in option spec: "engine|e=s{1,}"
> Error in option spec: "list|l=s{1,}"
> Error in option spec: "neglist|L=s{1,}"

Without the repeat specifiers Getopt::Long does not permit to skip repeated array option. For example, one can not write:

-l test1 test2 test3.

rather one would be required to enter:

-l test1 -l test2 - test3

i think the best curse of actions would be to back out the patch for bug  	418304 and leave that bug open for now.
 

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: patch

Comment 3

[Bob Clary [:bc] (inactive)]

(In reply to comment #1)

> 
> i think the best curse of actions would be to back out the patch for bug       
> 418304 and leave that bug open for now.

agreed.

Comment 4

[Bob Clary [:bc] (inactive)]

fixed by backout of bug 418304