Closed
Bug 430079
Opened 18 years ago
Closed 18 years ago
Remove some ancient style rules from dialog.css
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: stefanh, Assigned: stefanh)
Details
Attachments
(1 file)
|
1.79 KB,
patch
|
asaf
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
There are some old style rules in dialog.css that really should be removed. I doubt, for instance, that the background of a dialogheader should be "Highlight" and that the header-large background should be platinum-styled. There are also some other odd border-styles that I don't think should be there.
Attachment #316828 -
Flags: review?(mano)
|
Assignee | |
Comment 1•18 years ago
|
||
Btw, note that we don't display <dialogheader/>'s in prefs and Thunderbird hides it's <dialogheader/>'s in mail/themes/pinstripe/mail/accountManage.css#56.
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•18 years ago
|
||
Comment on attachment 316828 [details] [diff] [review]
Clean it up
r=mano
Attachment #316828 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 316828 [details] [diff] [review]
Clean it up
Safe clean-up
Attachment #316828 -
Flags: approval1.9?
|
||
Comment 4•18 years ago
|
||
Comment on attachment 316828 [details] [diff] [review]
Clean it up
a1.9+=damons
Attachment #316828 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•18 years ago
|
||
Comment on attachment 316828 [details] [diff] [review]
Clean it up
(landing this tomorrow)
|
|
Assignee | |
Comment 6•18 years ago
|
||
Checking in toolkit/themes/pinstripe/global/dialog.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/dialog.css,v <-- dialog.css
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•