430163 - Implement GetToggledKeyState on OS/2

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Peter Weilbacher]

Bug 377478 a long time ago implemented nsWindow::GetToggledKeyState for other platforms but didn't even add a no-op function for OS/2. I think I looked at this kind of keyboard readout at some point, maybe I can come up with something.

Comment 1

[Rich Walsh]

This should be closed as WONT_FIX or maybe WASTE_OF_TIME.  I can't find a single call to this method anywhere.  If it were actually used, it would be trivial to implement - but why bother?

Comment 2

[Peter Weilbacher]

I think I wanted to use it for something when I filed the bug but obviously never did. It could also be that some code outside the Mozilla trees (XULRunner apps, extensions) try to use it because it's part of nsIWidget.

And wasting of time can still be fun...

Comment 3

[Rich Walsh]

(In reply to comment #2)
> It could also be that some code outside the Mozilla trees (XULRunner
> apps, extensions) try to use it because it's part of nsIWidget.

I checked the code for TB & SM, plus searched for add-ons that mentioned this feature.  All I found was one add-on that's now obsolete.

Be that as it may, an implementation is attached...

Comment 4

[Rich Walsh]

Attachment: implements nsWindow::GetToggledKeyState

Comment 5

[Peter Weilbacher]

Comment on attachment 384568 [details] [diff] [review]
implements nsWindow::GetToggledKeyState

Thanks, looks good.

Comment 6

[Peter Weilbacher]

Pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/6ac21b65f123

I'm going to wait a bit and push it to the 1.9.1 branch in a few hours, if nothing bad happens.

Comment 7

[Peter Weilbacher]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/565979f49e10

Comment 8

[Aaron Train [:aaronmt]]

Rich/Peter,

Would you be willing to verify the fix for this bug on latest branch 1.9.1 as
it's on OS/2?

Thanks

Comment 9

[Peter Weilbacher]

Aaron, don't waste your time waiting for verification of OS/2 bugs. We currently don't do nightly builds, so this can take any amount of time. (We could skip fixed1.9.1 and directly go to verified1.9.1 if that helps you procedurally.)