430199 - Add "Undo Close Tab" option to right click menu on tab area

Status: ASSIGNED

(Other Applications :: ChatZilla, enhancement)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5
Build Identifier: 

It'd be nice to add an undo close tab option, like what Firefox has for tabs.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[James Ross]

Attachment: Undo Close Tab functionality in GUI

Comment 2

[James Ross]

Attachment: Basic undo close tab functionality

I certainly wouldn't call this done, but the basic functionality works. Some comments:
 - Restoring a tab's position relies on the view to its right at hide/delete time to be visible.
 - *Hidden* tabs count as closed tabs! I'm not sure if this is good/bad: I don't like hidden tabs counting towards the 10 limit, but I do like them reappearing in the "right" place.
 - Wording/visual aspect of "#foo (closed)" doesn't seem clear enough to me, and I'd like to have a proper, separate menu with just the closed views (in addition?).
 - It currently stores objects, not URLs, so cannot be persisted as-is. Not too hard to fix, though.
 - Let the user set the max views? Copy Firefox's pref value into our variable?

Comment 3

[Tony Mechelynck [:tonymec]]

I can't wait for this to get FIXED. Maybe also a new command? (/unhide-view and/or /undelete-view or some such?)

Comment 4

[James Ross]

Attachment: Undo close tab functionality with command and shortcut

Updated version of the code which correctly shows hidden/closed distinction (both still count towards total, probably going to keep it that way), unclose data is now suitable for serialisation and there is an /unclose-view command bound to Control-Shift-T. I removed all four Control-Shift-<letter> keys for toggling the UI (conflicts for tab bar) as I don't think they're actually that useful.