Closed Bug 430374 Opened 16 years ago Closed 15 years ago

"ASSERTION: we're not in galley mode" with table, -moz-column

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bernd_mozilla)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
677 bytes, text/html
Details
patch
1.51 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
Attached file testcase — 
###!!! ASSERTION: we're not in galley mode: 'NS_UNCONSTRAINEDSIZE == aReflowState.reflowState.availableHeight', file /Users/jruderman/trunk/mozilla/layout/tables/nsTableRowGroupFrame.cpp, line 938

Seems to be quirks-mode-only, which makes it hard to create a mostly-markup testcase (since the HTML parser doesn't like text in tables or tables without tbody elements).
the assert is obsolete now as is the comment above the function
Assignee: nobody → bernd_mozilla
Attached patch patch — — Splinter Review 

        Attachment #334149 -
        Flags: superreview?(bzbarsky)

        Attachment #334149 -
        Flags: review?(bzbarsky)

        Attachment #334149 -
        Flags: superreview?(bzbarsky)

        Attachment #334149 -
        Flags: superreview+

        Attachment #334149 -
        Flags: review?(bzbarsky)

        Attachment #334149 -
        Flags: review+

    
    

    
  
fix checked in
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
I checked the testcase as a crashtest.  It triggered an edge case
in the code so I thought it would be good to have in the testsuite.
(It passed all platforms on MozillaTry unit test)
http://hg.mozilla.org/mozilla-central/rev/62124009b06f
Flags: in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.