User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199) Gecko/20080404 Firefox/188.8.131.52 Build Identifier: Thunderbird version 184.108.40.206 (20080213) When printing an email with the French version, some (but not all) email headers have 2 colons instead of 1. For example: De : firstname.lastname@example.org Pour :: email@example.com Copie à :: firstname.lastname@example.org Reproducible: Always Steps to Reproduce: 1. Use Print preview with an email to see the problem The problem seems to be in the file /chrome/fr.jar : /locale/fr/messenger/mime.properties The following patch appears to solve the problem: --- mime.properties Tue Apr 24 11:52:00 2007 +++ mime.properties.new Mon Apr 21 19:43:53 2008 @@ -111 +111 @@ -1010=R\u00e9pondre \u00e0\u00a0: +1010=R\u00e9pondre \u00e0 @@ -121 +121 @@ -1012=Pour\u00a0: +1012=Pour @@ -127 +127 @@ -1013=Copie \u00e0\u00a0: +1013=Copie \u00e0 @@ -132 +132 @@ -1014=Forum\u00a0: +1014=Forum @@ -137 +137 @@ -1015=Faire suivre \u00e0\u00a0: +1015=Faire suivre \u00e0 @@ -177 +177 @@ -1023=Copie cach\u00e9e \u00e0\u00a0: +1023=Copie cach\u00e9e \u00e0
While the colon should go, I think the nbsp should stay there, and be added to some other lines. I'm not sure it is the right way to do BTW, hardcoding a colon in the code instead of putting it in the localizable strings is sure to cause l10y problems. What happens with RTL languages?
I understand your point about RTL languages. However, I suggest fixing the French double-colon first by removing it, so that this bug doesn't stay around for years. Then a different bug could be filed to move the colon out of the code into the localized strings in all languages.
Created attachment 317296 [details] [diff] [review] Patch removing extra semi-colons and adding nbsp where necessary
FIXED on trunk
Comment on attachment 317296 [details] [diff] [review] Patch removing extra semi-colons and adding nbsp where necessary >Index: mime.properties <...> > # CC > ## @name MIME_MHTML_CC > ## @loc > # LOCALIZATION NOTE (1013): Do not translate "CC" below. >-1013=Copie \u00e0\u00a0: >+1013=Copie \u00e0\u00a0 Really?
(In reply to comment #5) > > # CC > > ## @name MIME_MHTML_CC > > ## @loc > > # LOCALIZATION NOTE (1013): Do not translate "CC" below. > >-1013=Copie \u00e0\u00a0: > >+1013=Copie \u00e0\u00a0 > > Really? I'm not sure to understand. Is it about the "CC" that shouldn't be translated? It has been for years. Otherwise, this removes the extra colon and a non breakable space should be added before the colon added automatically as can be seen in the example in the initial description.
Comment on attachment 317296 [details] [diff] [review] Patch removing extra semi-colons and adding nbsp where necessary a=me, yeah, it won't get worse. Please land and test by the 6th (code freeze), even though I don't know if we're going to do a tb .15. Use the fixed... and verified220.127.116.11 keywords as usual.
FIXED Checking in mail/chrome/messenger/mime.properties; /l10n/l10n/fr/mail/chrome/messenger/mime.properties,v <-- mime.properties new revision: 18.104.22.168; previous revision: 22.214.171.124
Verified. version 126.96.36.199pre (20080605) build id: 2008060503