430419 - Command-Option-F does not select search box #2

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

this is same as bug 429160, but the cause is not same.

this is regression of bug 423814. in bug 423814, I changed that |performKeyEquivalent| return NO when Option or Control key is pressed for keyDown being called by OS. But when Cmd is pressed, keyDown is not called by OS. So, we need to call keyDown or processKeyDown from performKeyEquivalent when Cmd is also pressed.

I'll attach the patch for this.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

Sakai-san, would you test this patch on 10.5?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oops, I forgot a comment. The patch's concept was made by Sakai-san.

Comment 3

[Atsushi Sakai]

(In reply to comment #1)
> Sakai-san, would you test this patch on 10.5?

This patch works fine on 10.5.
Cmd+Opt+F works, and changing input modes of Kotoeri also works fine.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 317216 [details] [diff] [review]
Patch v1.0

Thank you, Sakai-san. Let's go to review process.

Comment 5

[Josh Aas]

Comment on attachment 317216 [details] [diff] [review]
Patch v1.0

Are you sure something like this wouldn't be more accurate?

if (modifierFlags & (NSControlKeyMask | NSAlternateKeyMask))
  ...

This will be true in 3 cases - "only control", "only alt", and "only control and alt". Your logic would be true any time either alt or control was down without command, including times where shift and/or function were also set. That might be what you want, just checking.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1

(In reply to comment #5)
> (From update of attachment 317216 [details] [diff] [review])
> Are you sure something like this wouldn't be more accurate?
> 
> if (modifierFlags & (NSControlKeyMask | NSAlternateKeyMask))
>   ...
> 
> This will be true in 3 cases - "only control", "only alt", and "only control
> and alt". Your logic would be true any time either alt or control was down
> without command, including times where shift and/or function were also set.
> That might be what you want, just checking.

No, the code includes the Cmd key pressing. But I combine the Ctrl and Alt checking in this patch.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 317465 [details] [diff] [review]
Patch v1.1

a1.9+=damons

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042806 Minefield/3.0pre ID:2008042806