[FIX]<object> mysteriously acquires type attribute (when plugin loads?)

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

({testcase})

Trunk
testcase
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Steps to reproduce:
1. Load http://software.hixie.ch/utilities/js/live-dom-viewer/?%3Cbody%3E%3Cobject%20data%3Dflash%3E
2. Add a space.

Result: The object element is shown as having an attribute
  type="application/x-shockwave-flash"

Expected: The object should continue to not have a type attribute.
Gah.  It looks like bug 277434 only sort of got fixed.  nsPluginStreamListenerPeer::OnStartRequest still calls SetType(), not SetActualType(), which is what's setting the attribute now...  Not that anyone _uses_ the thing it sets.  Which means this stuff was likely "broken" in 1.8 (writing to .type, reading .actualType), and no one ever noticed.  That argues that it's not so useful, to me.

In any case, now that we have nsObjectLoadingContent, which implements an actualType getter that has nothing to do with attributes, can we just rip out the nsPluginStreamListenerPeer::OnStartRequest code?  It would be good to not mess up the DOM like this...
Blocks: 244125
Flags: wanted1.9.0.x?
OS: Mac OS X → All
Hardware: PC → All
Created attachment 329565 [details] [diff] [review]
Rip this code out
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #329565 - Flags: superreview?(jst)
Attachment #329565 - Flags: review?(jst)
Summary: <object> mysteriously acquires type attribute (when plugin loads?) → [FIX]<object> mysteriously acquires type attribute (when plugin loads?)

Updated

10 years ago
Attachment #329565 - Flags: superreview?(jst)
Attachment #329565 - Flags: superreview+
Attachment #329565 - Flags: review?(jst)
Attachment #329565 - Flags: review+
Pushed http://hg.mozilla.org/index.cgi/mozilla-central/rev/f7a0a6d4d496
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: wanted1.9.0.x?
Resolution: --- → FIXED
Jesse, can you think of a way to test this?
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.