Closed
Bug 430448
Opened 17 years ago
Closed 17 years ago
Ugly white border at bottom of downloads manager
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: mossop, Assigned: kevin)
Details
Attachments
(4 files)
|
81.54 KB,
image/png
|
Details | |
|
779 bytes,
patch
|
Details | Diff | Splinter Review | |
|
27.11 KB,
image/png
|
Details | |
|
1.01 KB,
patch
|
beltzner
:
review+
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
With the mac theme update the download manager gained a nasty white border at the bottom.
Flags: blocking-firefox3?
| Reporter | ||
Comment 1•17 years ago
|
||
The problem is that the bottom toolbar ends up being 32px while the background image is just 31px high.
| Reporter | ||
Comment 2•17 years ago
|
||
This is a simple fix, shifts the background image to the bottom of the box. This moves the white border to the top but as the background fades it blends in reasonable well. However if the UI font grows then it will still look poor
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
| Reporter | ||
Comment 3•17 years ago
|
||
Attachment #317259 -
Flags: ui-review?(beltzner)
| Reporter | ||
Updated•17 years ago
|
Attachment #317257 -
Flags: review?(mconnor)
| Assignee | ||
Comment 4•17 years ago
|
||
this should be a bit more flexible
Attachment #317265 -
Flags: ui-review?
Comment 5•17 years ago
|
||
Comment on attachment 317265 [details] [diff] [review]
set background color of the area to match the bottom of the background-image
r+uir+a=beltzner
Attachment #317265 -
Flags: ui-review?
Attachment #317265 -
Flags: ui-review+
Attachment #317265 -
Flags: review+
Attachment #317265 -
Flags: approval1.9+
Updated•17 years ago
|
Attachment #317259 -
Flags: ui-review?(beltzner)
Updated•17 years ago
|
Attachment #317257 -
Flags: review?(mconnor)
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch][has reviews][has approval]
| Assignee | ||
Comment 6•17 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Assignee: dtownsend → kevin
Keywords: checkin-needed
Whiteboard: [has patch][has reviews][has approval]
Target Milestone: --- → Firefox 3
You need to log in
before you can comment on or make changes to this bug.
Description
•