Closed Bug 430448 Opened 17 years ago Closed 17 years ago

Ugly white border at bottom of downloads manager

Categories

(Firefox :: Theme, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: mossop, Assigned: kevin)

Details

Attachments

(4 files)

With the mac theme update the download manager gained a nasty white border at the bottom.
Flags: blocking-firefox3?
Attached image Eww
The problem is that the bottom toolbar ends up being 32px while the background image is just 31px high.
Attached patch quick fixSplinter Review
This is a simple fix, shifts the background image to the bottom of the box. This moves the white border to the top but as the background fades it blends in reasonable well. However if the UI font grows then it will still look poor
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attached image A bit better
Attachment #317259 - Flags: ui-review?(beltzner)
Attachment #317257 - Flags: review?(mconnor)
this should be a bit more flexible
Attachment #317265 - Flags: ui-review?
Comment on attachment 317265 [details] [diff] [review] set background color of the area to match the bottom of the background-image r+uir+a=beltzner
Attachment #317265 - Flags: ui-review?
Attachment #317265 - Flags: ui-review+
Attachment #317265 - Flags: review+
Attachment #317265 - Flags: approval1.9+
Attachment #317259 - Flags: ui-review?(beltzner)
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: checkin-needed
Whiteboard: [has patch][has reviews][has approval]
checked in
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee: dtownsend → kevin
Keywords: checkin-needed
Whiteboard: [has patch][has reviews][has approval]
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: